Skip to content

[LiPS] Verification dialog / full screen design adjustments #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
297d924
WIP.
carlosmuvi-stripe May 6, 2025
5fb8df2
Updates colors.
carlosmuvi-stripe May 6, 2025
c681e4f
Adds colors.
carlosmuvi-stripe May 6, 2025
fd231d3
Updates colors.
carlosmuvi-stripe May 6, 2025
a90a948
Updates darkMode.
carlosmuvi-stripe May 7, 2025
f421e19
Style fixes.
carlosmuvi-stripe May 7, 2025
66509ce
Updates screenshots.
carlosmuvi-stripe May 7, 2025
64de9d9
Ktlint fixes.
carlosmuvi-stripe May 7, 2025
b8c26d7
Merge branch 'carlosmuvi/add-link-design-v2-colors' into carlosmuvi/L…
carlosmuvi-stripe May 7, 2025
b095948
Updates colors.
carlosmuvi-stripe May 7, 2025
93a8d3a
Merge remote-tracking branch 'origin/master' into carlosmuvi/LINK_MOB…
carlosmuvi-stripe May 13, 2025
16dab96
Updates colors.
carlosmuvi-stripe May 14, 2025
0d76e30
Updates screenshots.
carlosmuvi-stripe May 14, 2025
3d5e3b1
Merge remote-tracking branch 'origin/master' into carlosmuvi/LINK_MOB…
carlosmuvi-stripe Jun 10, 2025
c05d145
Merge fixes.
carlosmuvi-stripe Jun 10, 2025
70ed344
Updates text color.
carlosmuvi-stripe Jun 10, 2025
8400810
Static analysis.
carlosmuvi-stripe Jun 10, 2025
ff28121
Regenerates screenshots.
carlosmuvi-stripe Jun 10, 2025
ce49367
Updates comment.
carlosmuvi-stripe Jun 10, 2025
e29df43
Adds missing screenshots.
carlosmuvi-stripe Jun 10, 2025
4a8f7d8
Adds missing screenshots.
carlosmuvi-stripe Jun 10, 2025
6804b83
Fixes screenshots.
carlosmuvi-stripe Jun 10, 2025
23dce60
Updates screenshots.
carlosmuvi-stripe Jun 10, 2025
d83e0cd
Merge remote-tracking branch 'origin/master' into carlosmuvi/LINK_MOB…
carlosmuvi-stripe Jun 10, 2025
5efb09b
Updates UI.
carlosmuvi-stripe Jun 10, 2025
f3c0cca
Reverts inline signup changes.
carlosmuvi-stripe Jun 10, 2025
06c05b3
Reverts inline signup changes.
carlosmuvi-stripe Jun 10, 2025
f3fad8c
Updates test.
carlosmuvi-stripe Jun 10, 2025
96502c0
Merge remote-tracking branch 'origin/master' into carlosmuvi/LINK_MOB…
carlosmuvi-stripe Jun 10, 2025
4a137b7
Adds new screenshots.
carlosmuvi-stripe Jun 10, 2025
42e3c41
Deletes screenshots.
carlosmuvi-stripe Jun 10, 2025
f006bd8
Reverts screenshots.
carlosmuvi-stripe Jun 10, 2025
7593956
Reverts screenshots.
carlosmuvi-stripe Jun 10, 2025
e8462a4
Reverts comment.
carlosmuvi-stripe Jun 10, 2025
9b489fa
Apply custom stroke width only to Link
tillh-stripe Jun 10, 2025
7890626
Merge branch 'master' into carlosmuvi/LINK_MOBILE-188_android-tweak-v…
tillh-stripe Jun 10, 2025
4ccb6ad
Fix lint
tillh-stripe Jun 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions paymentsheet/api/paymentsheet.api
Original file line number Diff line number Diff line change
Expand Up @@ -533,12 +533,32 @@ public final class com/stripe/android/link/ui/updatecard/ComposableSingletons$Up
public final fun getLambda-2$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
}

public final class com/stripe/android/link/ui/verification/ComposableSingletons$VerificationBodyKt {
public static final field INSTANCE Lcom/stripe/android/link/ui/verification/ComposableSingletons$VerificationBodyKt;
public fun <init> ()V
public final fun getLambda-1$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda-2$paymentsheet_release ()Lkotlin/jvm/functions/Function3;
}

public final class com/stripe/android/link/ui/verification/ComposableSingletons$VerificationDialogKt {
public static final field INSTANCE Lcom/stripe/android/link/ui/verification/ComposableSingletons$VerificationDialogKt;
public fun <init> ()V
public final fun getLambda-1$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda-2$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
}

public final class com/stripe/android/link/ui/verification/ComposableSingletons$VerificationScreenKt {
public static final field INSTANCE Lcom/stripe/android/link/ui/verification/ComposableSingletons$VerificationScreenKt;
public fun <init> ()V
public final fun getLambda-1$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda-2$paymentsheet_release ()Lkotlin/jvm/functions/Function3;
public final fun getLambda-3$paymentsheet_release ()Lkotlin/jvm/functions/Function2;
}

public final class com/stripe/android/link/ui/verification/VerificationDialogKt {
public static final fun VerificationDialogPreview (Landroidx/compose/runtime/Composer;I)V
}

public final class com/stripe/android/link/ui/verification/VerificationScreenKt {
public static final fun VerificationPreview (Landroidx/compose/runtime/Composer;I)V
}

public final class com/stripe/android/link/ui/verification/VerificationViewState$Creator : android/os/Parcelable$Creator {
Expand Down
2 changes: 2 additions & 0 deletions paymentsheet/detekt-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
<ID>LongMethod:USBankAccountForm.kt$@Composable private fun BillingDetailsForm( instantDebits: Boolean, formArgs: FormArguments, enabled: Boolean, isPaymentFlow: Boolean, nameController: TextFieldController, emailController: TextFieldController, phoneController: PhoneNumberController, addressController: AddressController, lastTextFieldIdentifier: IdentifierSpec?, sameAsShippingElement: SameAsShippingElement?, )</ID>
<ID>LongMethod:USBankAccountFormViewModel.kt$USBankAccountFormViewModel$private fun createNewPaymentSelection( resultIdentifier: ResultIdentifier, last4: String?, bankName: String?, billingDetails: PaymentMethod.BillingDetails, ): PaymentSelection.New.USBankAccount</ID>
<ID>LongMethod:UpdatePaymentMethodUI.kt$@Composable internal fun UpdatePaymentMethodUI(interactor: UpdatePaymentMethodInteractor, modifier: Modifier)</ID>
<ID>LongMethod:VerificationBody.kt$@Composable internal fun VerificationBody( state: VerificationViewState, otpElement: OTPElement, onBack: () -> Unit, onFocusRequested: () -> Unit, didShowCodeSentNotification: () -> Unit, onChangeEmailClick: () -> Unit, onResendCodeClick: () -> Unit, )</ID>
<ID>LongMethod:VerificationScreenshotTest.kt$VerificationScreenshotTest.Companion$private fun testCases(isDialog: Boolean): List&lt;TestCase></ID>
<ID>MagicNumber:NewPaymentMethodTabLayoutUI.kt$.3f</ID>
<ID>MagicNumber:NewPaymentMethodTabLayoutUI.kt$.4f</ID>
<ID>MagicNumber:NewPaymentMethodTabLayoutUI.kt$.5f</ID>
Expand Down
4 changes: 4 additions & 0 deletions paymentsheet/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ to be saved and used in future checkout sessions. -->
<string name="stripe_link_update_card_title">Update card</string>
<!-- Instructs the user to enter the code sent to their phone number in order to login to Link -->
<string name="stripe_link_verification_message">Enter the code sent to %s to use your saved information.</string>
<!-- Instructs the user to enter the code sent to their phone number in order to login to Link -->
<string name="stripe_link_verification_message_short">Enter the code sent to %s.</string>
<!-- Menu option to update card on the wallet screen on Link native -->
<string name="stripe_link_wallet_menu_action_update_card">Update card</string>
<!-- Title of the logout action. -->
Expand Down Expand Up @@ -226,6 +228,8 @@ to be saved and used in future checkout sessions. -->
<string name="stripe_upi_polling_payment_failed_title">Payment failed</string>
<!-- Title for a button that allows the user to use a different email in the signup flow. -->
<string name="stripe_verification_change_email">Change email</string>
<!-- Title for a button that allows the user to use a different email in the signup flow. -->
<string name="stripe_verification_change_email_new">Not you?</string>
<!-- Text of a notification shown to the user when a login code is successfully sent via SMS. -->
<string name="stripe_verification_code_sent">Code sent</string>
<!-- Two factor authentication screen heading -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,6 @@ internal object LinkThemeConfig {
selectedColor = LinkTheme.colors.buttonBrand,
unselectedColor = if (isSystemInDarkTheme()) Neutral700 else LinkTheme.colors.borderDefault
)

/**
* Scrim color does not have a match in the Link theme, so we use a default color matching Elements.
*/
internal val LinkColors.scrim: Color
get() = Color.Black.copy(alpha = 0.32f)
}

@Composable
Expand Down
Loading
Loading