-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCLite] Make FC Lite available in MPE #4712
Conversation
e30c967
to
fcbfefc
Compare
ee0a191
to
f793248
Compare
@@ -884,7 +888,7 @@ extension PlaygroundController { | |||
else { | |||
if let data = data, | |||
(response as? HTTPURLResponse)?.statusCode == 400 { | |||
let errorMessage = String(data: data, encoding: .utf8)! | |||
let errorMessage = String(decoding: data, as: UTF8.self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by fix. Our linter was yelling about this line
StripePaymentSheet/StripePaymentSheet/Source/Internal/FC Lite/FCLiteImplementation.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/Internal/FC Lite/FCLiteImplementation.swift
Outdated
Show resolved
Hide resolved
58d8ed9
to
14d244d
Compare
StripePaymentSheet- public var link: StripePaymentSheet.PaymentSheet.LinkConfiguration
- public struct LinkConfiguration {
- public var display: StripePaymentSheet.PaymentSheet.LinkConfiguration.Display
- public enum Display : Swift.String {
- case automatic
- case never
- public init?(rawValue: Swift.String)
- public typealias RawValue = Swift.String
- public var rawValue: Swift.String {
- get
- }
- }
- public init(display: StripePaymentSheet.PaymentSheet.LinkConfiguration.Display = .automatic)
- } If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
Summary
This integrates FC Lite into MPE. The main idea here is we first check if the full SDK is available, use that if so, and otherwise fallback on FC Lite.
Important
This PR does not release FC Lite. There is a guardrail in place (
fcLiteFeatureEnabled
) that prevents it from being accessed, and this is only currently enabled by our example apps.Motivation
Testing
Manual testing done! Here's the Payment Sheet example app:
Screen.Recording.2025-03-27.at.1.12.51.PM.mov
And the Financial Connections example app:
Screen.Recording.2025-03-27.at.1.15.08.PM.mov
Changelog
N/a