-
Notifications
You must be signed in to change notification settings - Fork 1k
[FCLite] Make FC Lite available in MPE #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
079114c
[FCLite] Make FC Lite available in MPE
mats-stripe a7e216e
Add FC Lite killswitch and priority override
mats-stripe a41e1ef
Add guardrails preventing FCLite be available outside test apps
mats-stripe fe2acfd
Fix linting error in PlaygroundController
mats-stripe 14d244d
Add unit test for FCLiteImplementation availability
mats-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
StripePaymentSheet/StripePaymentSheet/Source/Internal/FC Lite/FCLiteImplementation.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // | ||
| // FCLiteImplementation.swift | ||
| // StripePaymentSheet | ||
| // | ||
| // Created by Mat Schmid on 2025-03-25. | ||
| // | ||
|
|
||
| @_spi(STP) import StripeCore | ||
| import UIKit | ||
|
|
||
| /// NOTE: If you change the name of this class, make sure to also change it in the `FinancialConnectionsSDKAvailability` file. | ||
| @_spi(STP) public class FCLiteImplementation: FinancialConnectionsSDKInterface { | ||
| required public init() {} | ||
|
|
||
| public func presentFinancialConnectionsSheet( | ||
| apiClient: STPAPIClient, | ||
| clientSecret: String, | ||
| returnURL: String?, | ||
| style: FinancialConnectionsStyle, | ||
| elementsSessionContext: ElementsSessionContext?, | ||
| onEvent: ((FinancialConnectionsEvent) -> Void)?, | ||
| from presentingViewController: UIViewController, | ||
| completion: @escaping (FinancialConnectionsSDKResult) -> Void | ||
| ) { | ||
| let returnUrl = returnURL.flatMap(URL.init(string:)) | ||
|
|
||
| let fcLite = FinancialConnectionsLite( | ||
| clientSecret: clientSecret, | ||
| returnUrl: returnUrl | ||
| ) | ||
| fcLite.present(from: presentingViewController, completion: completion) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/FCLiteImplementationTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // FCLiteImplementationTests.swift | ||
| // StripePaymentSheetTests | ||
| // | ||
| // Created by Mat Schmid on 2025-03-28. | ||
| // | ||
|
|
||
| @_spi(STP) import StripeCore | ||
| import XCTest | ||
|
|
||
| class FCLiteImplementationTests: XCTestCase { | ||
| func testFCLiteImplementationAvailable() { | ||
| let FinancialConnectionsLiteImplementation: FinancialConnectionsSDKInterface.Type? = | ||
| NSClassFromString("StripePaymentSheet.FCLiteImplementation") | ||
| as? FinancialConnectionsSDKInterface.Type | ||
| XCTAssertNotNil(FinancialConnectionsLiteImplementation) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by fix. Our linter was yelling about this line