Stream app logs from s3 archive #4339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for streaming historical app logs from an S3 archive bucket through the
fly logscommand.This adds several new flags,
start,end, andlimitto control the time-range and length of logs to stream.The implementation first grabs an AWS session from the new GetS3LogsToken flaps endpoint (this depends on superfly/fly-go#151), and uses that AWS session to interact with the AWS API directly to list all the relevant S3 objects in the org's bucket prefix, then download, decompress and stream (in timestamp-sorted order) all of the relevant logs within the specified time-range (and app/instance/region) filter.
Documentation