Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor training loop from script to class #26

Closed
wants to merge 2 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 12, 2023

Description

This PR refactors the training loop from a script to a class in order to improve organization and reusability. The existing code in src/main.py is refactored into a new class named MNISTTrainer. The Net class is also updated to include a train method that utilizes the MNISTTrainer class.

Summary of Changes

  • Created a new class MNISTTrainer in src/main.py to handle the loading, preprocessing, and training of the MNIST data.
  • Moved the code for loading and preprocessing the data into the __init__ method of MNISTTrainer.
  • Added a train method to MNISTTrainer that contains the training loop for the model.
  • Updated the Net class in src/main.py to include a train method that creates an instance of MNISTTrainer and calls its train method.
  • Updated the predict function in src/api.py to use the new train method of the Net class.

Please review and merge this PR. Thank you!

Fixes #6.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/api.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot added the sweep label Oct 12, 2023
@sweep-nightly sweep-nightly bot closed this Oct 12, 2023
@sweep-nightly sweep-nightly bot deleted the sweep/refactor-training-loop_4 branch October 12, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: refactor the training loop from a script to a class in main.py
0 participants