Conversation
marinaaisa
force-pushed
the
update-node
branch
3 times, most recently
from
c2c82d5 to
19393a9
Compare
|
@swift-ci test |
marinaaisa
force-pushed
the
update-node
branch
7 times, most recently
from
8e0add4 to
83abe23
Compare
marinaaisa
force-pushed
the
update-node
branch
3 times, most recently
from
0e6f08d to
42e07a6
Compare
|
@swift-ci test |
|
@swift-ci test |
|
tree-sitter-vue is not compatible with Node.js 22. The version of tree-sitter that works with Node.js 22 is v0.21.0 or later, as it uses the new Node-API instead of NAN for its Node bindings. Since tree-sitter-vue hasn't been updated to use v0.21.0+, it doesn't work with Node.js 22. Related: rdar://156714814 I opened a separate PR in case we want to delete the tree-sitter-vue dependency, since it doesn't work with Node 22. |
We need to update the Node version to 22.17.0 for the Swift CI to work in Docc-render, since we are also updating Node in the project. [1] [1] swiftlang/swift-docc-render#952
We need to update the Node version to 22.17.0 in the Swift CI for Docc-Render, to ensure compatibility with the updated Node version used in the project. [1] [1] swiftlang/swift-docc-render#952
|
Swift CI is failing because it's using Node 14.17.4 instead of Node I opened a PR in Swift Docker to update the Node version in Docker to Fixes: rdar://156708326 |
marinaaisa
force-pushed
the
update-node
branch
from
bd2ee89 to
3acc738
Compare
|
@swift-ci test |
This change fixes the deprecation warning: [Vue warn]: Duplicate keys detected: 'A'. This may cause an update error.
marinaaisa
force-pushed
the
update-node
branch
from
a4ce39a to
529ae65
Compare
By aiming to update the Node version to 22.17.0 on Swift Docker for Swift DocC Render [1], we need to specify the version 3 of python, otherwise it will try to use python 2 which it's not available in Node 22. [1] swiftlang/swift-docker#487
Conflicts: build-script-helper.py
mportiz08
left a comment
mportiz08
left a comment
There was a problem hiding this comment.
Looks good.
Trying to figure out the right way to test/merge the swift-docker PR which will unblock the tests for this PR (and merging it).
We need to update the Node version to 22.17.0 in the Swift CI for Docc-Render, to ensure compatibility with the updated Node version used in the project. [1] [1] swiftlang/swift-docc-render#952
3 participants
Bug/issue #137038442, if applicable:
Summary
This change updates Node.js to
22.17.0& NPM to10.9.2.I chose 22.17.0 version of Node because it's the latest LTS (Long Term Support) version.
Dependencies
NA
Testing
Steps:
rm -rf node_modules package-lock.jsonnpm installnpm run servenpm run testChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded