[workflow] Trigger format server when @taichi-gardener is requested for review#1026
[workflow] Trigger format server when @taichi-gardener is requested for review#1026archibate merged 9 commits intotaichi-dev:masterfrom
Conversation
|
Hello? Feel free to say |
Sorry, I've got some work to do over the day, but I'll take a look at this later. Thanks for the PR! |
|
My biggest worry about this is that, if a PR author adds a comment for formatting their code, all the reviewers will receive that comment as well. This creates too much noise in the reviewers' mailbox. As a result, they will start to ignore emails from GitHub regarding Taichi. |
|
Then, how about: |
|
I just come up with that, we can hook on review_requested event: |
This sounds great!! |
|
OK now! |
yuanming-hu
left a comment
There was a problem hiding this comment.
Thanks! LGTM! Just one minor place that needs discussions.
|
|
||
| [[Click here for the format server]](http://kun.csail.mit.edu:31415/) |
There was a problem hiding this comment.
Maybe we should keep this here for a while, just in case some newcomers do not have access to reviewer assignment?
There was a problem hiding this comment.
Oh, sorry, I almost forget that review requesting needs write-access...
|
We will make |
|
Hello? I want to merge this for 'enjoyment' in other prs. |
yuanming-hu
left a comment
There was a problem hiding this comment.
LGTM. Thank you! Let's see how it works :-)
Related issue = #... (if any)
[Click here for the format server]
Demo: taichi-dev/test_actions#4