-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add benchmark to postsubmit workflow #3220
[ci] Add benchmark to postsubmit workflow #3220
Conversation
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: 1266ce1 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61763b9c158fca0007a52568 😎 Browse the preview: https://deploy-preview-3220--jovial-fermat-aa59dc.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (for postsubmit workflow it's always good to test in test_actions first ;)
.github/workflows/postsubmit.yml
Outdated
|
||
performance_monitoring: | ||
name: Performance monitoring (NVGPU) | ||
needs: check_code_format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no check_code_format
in the postsubmit workflow right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I used presubmit workflow in test_actions to test it before. 😆
[ci] Benchmark presubmit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks!
Related issue = #2632