Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add benchmark to postsubmit workflow #3220

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

yolo2themoon
Copy link
Collaborator

Related issue = #2632

@netlify
Copy link

netlify bot commented Oct 18, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 1266ce1

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61763b9c158fca0007a52568

😎 Browse the preview: https://deploy-preview-3220--jovial-fermat-aa59dc.netlify.app

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/postsubmit.yml Outdated Show resolved Hide resolved
.github/workflows/postsubmit.yml Outdated Show resolved Hide resolved
benchmarks/misc/run.py Outdated Show resolved Hide resolved
benchmarks/misc/run.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (for postsubmit workflow it's always good to test in test_actions first ;)


performance_monitoring:
name: Performance monitoring (NVGPU)
needs: check_code_format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no check_code_format in the postsubmit workflow right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I used presubmit workflow in test_actions to test it before. 😆
[ci] Benchmark presubmit test

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants