-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] Pass DebugInfo to frontend statements #8295
Merged
dream189free
merged 27 commits into
taichi-dev:master
from
dream189free:error-emitter-5
Jul 26, 2023
Merged
[lang] Pass DebugInfo to frontend statements #8295
dream189free
merged 27 commits into
taichi-dev:master
from
dream189free:error-emitter-5
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit 91695a4.
dream189free
force-pushed
the
error-emitter-5
branch
from
July 21, 2023 08:05
8a5cca9
to
85869be
Compare
jim19930609
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at 734486d
This pull request adds a new parameter
dbg_info
to various classes and functions intaichi/ir
andtaichi/ir/frontend_ir
that are related to creating and storing IR statements and expressions. The goal is to pass the debug information from the frontend to the IR, which will enable better error reporting in Taichi.Walkthrough
🤖 Generated by Copilot at 734486d
dbg_info
to the constructors of various classes that inherit fromStmt
orExpression
classes, and pass or assign it to the base constructor or thedbg_info
field of the class. The purpose of these changes is to pass the debug information from the frontend to the IR for better error reporting. (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)