Skip to content

[build] Upgrade Vulkan and Fix imgui #8715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[build] Upgrade Vulkan and Fix imgui #8715

wants to merge 13 commits into from

Conversation

johnnynunez
Copy link
Contributor

No description provided.

@johnnynunez johnnynunez changed the title Upgrade Vulkan and Fix imgui [build] Upgrade Vulkan and Fix imgui May 8, 2025
@hughperkins
Copy link
Contributor

Oh we both made a similar PR :) 🎉

@johnnynunez
Copy link
Contributor Author

Oh we both made a similar PR :) 🎉

I split all my changes, so I create 6-7 PR's

@hughperkins
Copy link
Contributor

Yeah nice :)

@johnnynunez
Copy link
Contributor Author

Yeah nice :)

Also I fixed finally open3d for ARM64 isl-org/Open3D#7239

@hughperkins
Copy link
Contributor

Interesting 💪

johnnynunez added 8 commits May 8, 2025 14:33
@johnnynunez
[feature] Add support for extracting .tar.xz archives in dep.py (#8)
2cae070
@johnnynunez
[llvm] Enhance LLVM installation logic for specific Linux architectur…
c3e8aa2 
…es (#7)
@johnnynunez
[fix] Update setup function to use Miniforge and correct download URLs (
323026b 
#6)
@johnnynunez
[build] Replace libtinfo-dev with libncurses-dev in package dependenc…
fb220b7 
…ies (#5)
@johnnynunez
[fix] Update sccache download URLs to version 0.10.0 for various plat…
bc504cb 
…forms (#4)
@johnnynunez
[fix] Update platform detection for manylinux support on ARM architec…
fde8884 
…tures (#3)
@johnnynunez
Vulkan (#2)
998d76c 
* [update] Upgrade Vulkan SDK to version 1.4.309.0 and add support for ARM64 on Linux

* [update] Refactor ImGui Vulkan integration for compatibility with version ≥ 1.90

* [logging] Include ranges header from spdlog for enhanced formatting capabilities
@johnnynunez
[update] Update hash values for various dependencies (#1)
2efbff4
@hughperkins
Copy link
Contributor

@johnnynunez Thoughts on these test errors I'm seeing in my own Vulkan upgrade branch?

https://github.com/taichi-dev/taichi/actions/runs/14905225451/job/41865963509?pr=8722

Screenshot 2025-05-08 at 9 40 41 AM

I don't see any evidence that it's an infrastructure issue, and I'm leaning towards this is something that changed in the Vulkan api behavior? Thoughts? What happens when you run the CI script on your own infra?

@hughperkins
Copy link
Contributor

Note: for some reason this downloads x86 version on my arm system 🤔

:: -----END Setup LLVM-----
:: -----BEGIN Setup Vulkan 1.4.309.0-----
vulkansdk-linux-x86_64-1.4.309.0.tar.xz:   1%|█▎                                                                                              | 3.95M/285M [00:04<02:41, 1.83MB/s]
vulkansdk-linux-x86_64-1.4.309.0.tar.xz:   1%|█▎                                                                                               | 3.96M/285M [00:04<05:52, 836kB/s]
!! -----EXCEPTION Setup Vulkan 1.4.309.0-----

hugh@u22taichi:~/git/taichi$ uname -a
Linux u22taichi 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:07:32 UTC 2025 aarch64 aarch64 aarch64 GNU/Linux

@hughperkins
Copy link
Contributor

Oh, that's probably because I merged this onto my previous vulkan pr that doesnt include arm. Cool :)

@hughperkins
Copy link
Contributor

wait, no, it's because if u.system == "Linux": matches all linux systems, rigth?

hughperkins
hughperkins reviewed May 10, 2025
View reviewed changes
.github/workflows/scripts/ti_build/vulkan.py Outdated
os.environ["VK_LAYER_PATH"] = str(sdk / "etc" / "vulkan" / "explicit_layer.d")
elif (u.system, u.machine) in (("Linux", "arm64"), ("Linux", "aarch64")):
url = (
"https://github.com/johnnynunez/vulkan-sdk-arm/releases/download/1.4.309.0/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt exist 😛 Your release is 1.4.304.1 right? https://github.com/johnnynunez/vulkan-sdk-arm/releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to upload new release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uploaded https://github.com/johnnynunez/vulkan-sdk-arm/releases/tag/1.4.313.0

danielshaked9
danielshaked9 reviewed Jun 9, 2025
View reviewed changes
Copy link

@danielshaked9 danielshaked9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this broke the entire client side ecosystem and is causing all vulkan assertion errors.
i thinking pushing this into production right after drivers updates releases is a mistake. we care about taichi guys lets do it properly. taichi was built to ease the way we simulate our scientific ideas, not to be compatible and highly efficient on edge lowcost devices.

@johnnynunez
Copy link
Contributor Author

this broke the entire client side ecosystem and is causing all vulkan assertion errors. i thinking pushing this into production right after drivers updates releases is a mistake. we care about taichi guys lets do it properly. taichi was built to ease the way we simulate our scientific ideas, not to be compatible and highly efficient on edge lowcost devices.

Gh200/GB200 are devices that cost more than 50k. Devices that I’m using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hughperkins hughperkins hughperkins left review comments

@danielshaked9 danielshaked9 danielshaked9 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnnynunez @hughperkins @danielshaked9