chore(consensus): rename ANCHOR_V3_GAS_LIMIT to ANCHOR_V3_V4_GAS_LIMIT

[davidtaikocha]

No description provided.

[claude]

Claude finished @davidtaikocha's task —— View job

---

Code Review Complete ✓

Tasks

• Read the modified file to understand changes
• Search for any remaining references to old constant name
• Check test coverage
• Provide review feedback

---

Review Feedback

✅ Code Quality

The rename is clean and correct. The change updates:

• Constant definition at crates/consensus/src/validation.rs:46
• Usage at crates/consensus/src/validation.rs:286
• Documentation comment accurately reflects new scope

✅ Naming Convention

The new name ANCHOR_V3_V4_GAS_LIMIT properly follows the existing pattern (ANCHOR_V1_V2_GAS_LIMIT) and accurately reflects that this gas limit applies to both Pacaya (anchorV3) and Shasta (anchorV4) hardforks.

✅ Completeness

No stray references to ANCHOR_V3_GAS_LIMIT remain in the codebase (only git metadata).

📝 Minor Observations

1. Documentation clarity: The updated comment "The gas limit for the anchor transactions in Pacaya and Shasta hardfork blocks" is accurate, but could be more precise. Consider:

   /// The gas limit for anchor transactions from Pacaya hardfork onwards (anchorV3 and anchorV4).
   

2. Test coverage: The constant is used in validation logic at line 286, but there's no dedicated test verifying the gas limit validation for anchor transactions. The existing tests focus on selector validation and base fee calculation. Consider adding a test that validates gas limit enforcement for different hardfork scenarios.

3. Branch name: Minor note - the branch is still named ANCHOR_V3_GAS_LIMIT, which doesn't match the new constant name (not a blocker, just noting for future reference).

✅ Security & Performance

No concerns. This is a pure refactoring with no logic changes.

---

Recommendation: ✅ APPROVE - This is a clean refactoring that improves code clarity. The minor suggestions above are optional enhancements, not blockers.

---