Fix incorrect behavior of isTyping#3596
Closed
velopsey wants to merge 1 commit intotailwindlabs:mainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@RobinMalfait I’d really appreciate it if you could take a look at this fix. It’s simple and easy to understand, and I’m happy to respond quickly to any questions or feedback. This will genuinely help my company (takeda.com) |
aliventsevtakeda
approved these changes
Dec 16, 2024
Member
|
Hey! Sorry about the delay, but thanks for the PR! The PR was a bit behind, so rebasing wasn't as straight forward. To keep things easy, I opened a new PR (#3785) to solve this issue. I also added you as a co-author of that PR. Thanks again! |
pull bot
pushed a commit
to Tiamat-Tech/headlessui
that referenced
this pull request
Sep 5, 2025
…ut value (tailwindlabs#3785) We prevent syncing the `ComboboxInput` value while you are typing. However, when you press `Tab` there is keyboard event causing the component to be marked as if you are currently typing. But since we are tabbing away from the input we should not be "typing" anymore. This ensures that the `input` can be updated with whatever the current value should be. Fixes: tailwindlabs#3738 Fixes: tailwindlabs#3595 Fixes: tailwindlabs#3537 Closes: tailwindlabs#3596 --------- Co-authored-by: Daniil Savitskii <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where navigating from one
Comboboxto another using the Tab key blocked thedisplayValuefrom updating in the next render.The issue was partially introduced in this PR: #3259.
Currently, any interaction with the keyboard activates a mode that prevents the value from being updated.
My fix is a straightforward solution, but as maintainers of this library, you may have a better idea of how to address this bug. I’d be happy to implement any suggestions you provide.
Thank you for your work — this library truly helps make my interfaces better
Fixes: #3595