Ensure pressing Tab in the ComboboxInput, correctly syncs the input value#3785
Merged
RobinMalfait merged 3 commits intomainfrom Sep 5, 2025
Merged
Ensure pressing Tab in the ComboboxInput, correctly syncs the input value#3785RobinMalfait merged 3 commits intomainfrom
Tab in the ComboboxInput, correctly syncs the input value#3785RobinMalfait merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RobinMalfait
force-pushed
the
fix/issue-3738
branch
from
46f9eea to
5da5d5b
Compare
We prevent syncing the `ComboboxInput` state while you are typing. However, when you press `Tab` there is keyboard event, but since we are tabbing away from the input we should not be "typing" anymore. This ensures that the `input` can be updated with whatever the current value should be. Co-authored-by: Daniil Savitskii <[email protected]>
RobinMalfait
force-pushed
the
fix/issue-3738
branch
from
f8fe539 to
55f8e9a
Compare
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We prevent syncing the
ComboboxInputvalue while you are typing. However, when you pressTabthere is keyboard event causing the component to be marked as if you are currently typing. But since we are tabbing away from the input we should not be "typing" anymore.This ensures that the
inputcan be updated with whatever the current value should be.Fixes: #3738
Fixes: #3595
Fixes: #3537
Closes: #3596