Make test the default branch

[eberrigan]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors environment handling by making test the default branch for Terraform workflows and adds UI/API improvements for VM management.

• CI/CD: Update GitHub Actions to target test and main branches and support dynamic environment selection with per-env backend config.
• UI/API: Add real-time unassigned VM count polling, .slp extraction/download UI and endpoints, and AWS credential error alerts.
• Config/schema: Introduce ami_id and repository in structured config, and provide environment-specific Terraform backend HCL files.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
templates/index.html	Added live unassigned VM count display with polling script.
templates/delete-instances.html	Revamped delete page UI, added extract form, spinner, success/error.
templates/dashboard.html	Introduced AWS credentials error alert block.
templates/admin.html	Updated button text and added AWS-credentials success message.
main.py	Added /api/scp-client and /api/unassigned_vms_count endpoints; ANSI-escape stripping; enhanced error handling.
database.py	Added get_row_count method.
conf/structured_config.py	Added new ami_id field to MachineConfig.
conf/config.yaml	Updated ami_id and repository defaults.
backend_config.tf, backend.tf, backend-*.hcl	Removed static backend; added per-env HCL for dynamic backend.
Dockerfile	Installed rsync and openssh-client for file transfers.
.devcontainer/devcontainer.json	Removed unnecessary features; adjusted forwarded ports.
.github/workflows/*.yml	Constrained workflows to test/main; added environment/image input logic.

Comments suppressed due to low confidence (4)

lablink-allocator/lablink-allocator-service/main.py:352

• [nitpick] Consider adding a docstring above this route to describe its purpose, input requirements, and response format for better maintainability.

@app.route("/api/scp-client", methods=["GET"])

lablink-allocator/lablink-allocator-service/main.py:432

• [nitpick] This new endpoint lacks unit or integration tests. Consider adding tests to verify the JSON response under normal and empty-database conditions.

@app.route("/api/unassigned_vms_count", methods=["GET"])

lablink-allocator/lablink-allocator-service/main.py:166

• [nitpick] This /api/admin/set-aws-credentials route returns HTML instead of JSON. For consistency, either rename the endpoint to remove /api or return a JSON payload and handle the success message client-side.

return render_template("admin.html", message="AWS credentials set successfully.")

lablink-allocator/lablink-allocator-service/main.py:51

• The code references os.getenv and later os.remove without importing the os module. Please add import os at the top of the file to avoid a NameError.

allocator_ip = os.getenv("ALLOCATOR_PUBLIC_IP")

[Copilot]

[nitpick] Navigating via window.location.href unloads the page immediately, preventing the spinner and cleanup logic from running. Consider using fetch or XMLHttpRequest to download the file and manage the UI state.

Suggested change

	window.location.href = "/api/scp-client";
	setTimeout(() => {
	loading.classList.add("d-none");
	btn.disabled = false;
	btn.innerText = "Extract and Download .slp Files";
	btn.classList.remove("disabled");
	destroyBtn.disabled = false;
	destroyBtn.classList.remove("disabled");
	}, 10000);
	try {
	const response = await fetch("/api/scp-client");
	if (!response.ok) {
	throw new Error("Failed to download files");
	}
	const blob = await response.blob();
	const url = URL.createObjectURL(blob);
	const a = document.createElement("a");
	a.href = url;
	a.download = "files.slp";
	document.body.appendChild(a);
	a.click();
	URL.revokeObjectURL(url);
	success.classList.remove("d-none");
	} catch (err) {
	error.classList.remove("d-none");
	console.error("Error during extraction:", err);
	} finally {
	loading.classList.add("d-none");
	btn.disabled = false;
	btn.innerText = "Extract and Download .slp Files";
	btn.classList.remove("disabled");
	destroyBtn.disabled = false;
	destroyBtn.classList.remove("disabled");
	}