-
Notifications
You must be signed in to change notification settings - Fork 7
Auto compute max height and width from labels #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## divya/fix-ld-optimize #101 +/- ##
=========================================================
+ Coverage 97.35% 97.37% +0.01%
=========================================================
Files 38 38
Lines 3595 3622 +27
=========================================================
+ Hits 3500 3527 +27
Misses 95 95 ☔ View full report in Codecov by Sentry. |
86816a5 to
23cb61e
Compare
This reverts commit 9cd6d0b.
This PR adds the functionality to compute the maximum height and width of images across the labels file based on which the images are padded to ensure the image shapes are consistent across the dataset. Previously, users were required to provide the max height and width in the config (
data_config.preprocessing). If these fields areNone, then the images wouldn't be padded even if the dimensions were inconsistent.With this PR, if the
max_heightandmax_widthprovided by the user in the config areNone, the data pipeline computes these automatically from the labels file, which are then used for padding. If values are explicitly set in the config, the user-defined values will take precedence over the computed ones.