Editorial: Split total() code path out of RoundRelativeDuration #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2758 we kept the code paths for Duration.p.round() and Duration.p.total() the same. However, it is actually simpler to separate them in most places, except for NudgeToCalendarUnit. - Splits TotalRelativeDuration out of RoundRelativeDuration - Splits TotalTimeDuration out of RoundTimeDuration - Splits DifferenceZonedDateTimeWithTotal out of DifferenceZonedDateTimeWithRounding - Splits DifferencePlainDateTimeWithTotal out of DifferencePlainDateTimeWithRounding - Removes [[Total]] field from Nudge Result Record - Changes NudgeToCalendarUnit to return a record of { [[NudgeResult]], [[Total]] } Closes: #2947
|
cc @arshaw |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
+ Coverage 96.35% 96.37% +0.02%
==========================================
Files 21 21
Lines 10519 10578 +59
Branches 1803 1810 +7
==========================================
+ Hits 10136 10195 +59
Misses 325 325
Partials 58 58 ☔ View full report in Codecov by Sentry. |
27 tasks
Ms2ger
approved these changes
Oct 1, 2024
|
Looks good to me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2758 we kept the code paths for Duration.p.round() and Duration.p.total() the same. However, it is actually simpler to separate them in most places, except for NudgeToCalendarUnit.
Closes: #2947