Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Split total() code path out of RoundRelativeDuration #2987

Merged
merged 1 commit into from
Oct 1, 2024

Commits on Sep 30, 2024

  1. Editorial: Split total() code path out of RoundRelativeDuration

    In #2758 we kept the code paths for Duration.p.round() and
    Duration.p.total() the same. However, it is actually simpler to separate
    them in most places, except for NudgeToCalendarUnit.
    
    - Splits TotalRelativeDuration out of RoundRelativeDuration
    - Splits TotalTimeDuration out of RoundTimeDuration
    - Splits DifferenceZonedDateTimeWithTotal out of
      DifferenceZonedDateTimeWithRounding
    - Splits DifferencePlainDateTimeWithTotal out of
      DifferencePlainDateTimeWithRounding
    - Removes [[Total]] field from Nudge Result Record
    - Changes NudgeToCalendarUnit to return a record of { [[NudgeResult]],
      [[Total]] }
    
    Closes: #2947
    ptomato committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7326e72 View commit details
    Browse the repository at this point in the history