Override (Sourcery refactored)

[sourcery-ai]

Pull Request #13 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the override branch, then run:

git fetch origin sourcery/override
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function single_ctx_desc refactored with the following changes:

• Remove unnecessary else after guard condition (remove-unnecessary-else)

[sourcery-ai]

Function lookup_hw_from_map refactored with the following changes:

• Remove redundant conditional (remove-redundant-if)
• Use items() to directly unpack dictionary values (use-dict-items)

This removes the following comments ( why? ):

# Compare other attribute types ...

[sourcery-ai]

Function find_contexts refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.69%.

Quality metrics	Before	After	Change
Complexity	27.68 😞	25.46 😞	-2.22 👍
Method Length	79.50 🙂	79.00 🙂	-0.50 👍
Working memory	9.99 😞	10.18 😞	0.19 👎
Quality	50.36% 🙂	51.05% 🙂	0.69% 👍

Other metrics	Before	After	Change
Lines	245	237	-8

Changed files	Quality Before	Quality After	Quality Change
pytest_libiio/plugin.py	50.36% 🙂	51.05% 🙂	0.69% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
pytest_libiio/plugin.py	lookup_hw_from_map	63 ⛔	177 😞	16 ⛔	19.45% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pytest_libiio/plugin.py	_contexts	18 🙂	178 😞	10 😞	43.77% 😞	Try splitting into smaller methods. Extract out complex expressions
pytest_libiio/plugin.py	find_contexts	8 ⭐	125 😞	11 😞	56.02% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!