Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override (Sourcery refactored) #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Override (Sourcery refactored) #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions pytest_libiio/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@ def single_ctx_desc(request, _contexts):
hardware = hardware if isinstance(hardware, list) else [hardware]
if not marker:
return _contexts[0]
else:
for dec in _contexts:
if dec["hw"] in marker.args[0]:
return dec
for dec in _contexts:
if dec["hw"] in marker.args[0]:
return dec
Comment on lines -95 to +97
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function single_ctx_desc refactored with the following changes:

pytest.skip("No required hardware found")


Expand Down Expand Up @@ -200,16 +199,12 @@ def lookup_hw_from_map(ctx, map):
for attr_dict in driver_or_attr["ctx_attr"]:
for attr_name in attr_dict:
# loop over found and compare to
for hw_ctx_attr in ctx_attrs:
for hw_ctx_attr, value in ctx_attrs.items():
if (
hw_ctx_attr == attr_name
and attr_dict[attr_name]
in ctx_attrs[hw_ctx_attr]
and attr_dict[attr_name] in value
):
found += 1
# Compare other attribute types ...
if attr_type == "dev_attr":
pass
Comment on lines -203 to -212
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function lookup_hw_from_map refactored with the following changes:

This removes the following comments ( why? ):

# Compare other attribute types ...

continue
# Loop over drivers
for h in hw:
Expand All @@ -231,10 +226,7 @@ def lookup_hw_from_map(ctx, map):


def find_contexts(config, map, request):
if request.config.getoption("--skip-scan"):
ctxs = None
else:
ctxs = iio.scan_contexts()
ctxs = None if request.config.getoption("--skip-scan") else iio.scan_contexts()
Comment on lines -234 to +229
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function find_contexts refactored with the following changes:

if not ctxs:
print("\nNo libiio contexts found")
return False
Expand Down