Remove legacy templates #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L1ghtmann
approved these changes
Jan 27, 2025
Member
L1ghtmann
left a comment
L1ghtmann
left a comment
There was a problem hiding this comment.
Thanks for spearheading this, Leptos! Only comment for the pr is we should probably remove the templates from the README list too. Tangentially, we should update the docs to reflect the changes. I can help with some or all of that if desired!
Member
Author
|
Great call, thank you! That would be helpful, yes please - may you (or anyone else) add the docs change? |
uroboro
approved these changes
Jan 31, 2025
leptos-null
added a commit
to theos/templates-legacy
that referenced
this pull request
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
In an effort for the default set of templates to be as helpful as possible, this PR removes templates that target older operating systems and configurations.
The templates being removed in this PR will be moved to a Theos module. This PR will only be merged after that module is available. This PR represents the place to discuss which templates move over to that module.
(Based on conversation in #31 (comment))
Important note: #31 effectively removes
iphone/applicationfrom this repository (as it is legacy). That template is not removed in this PR since #31 already does. Theiphone/applicationtemplate will be moved over to the "legacy templates" module.Does this close any currently open issues?
No
Any relevant logs, error output, etc?
No
Any other comments?
There is some additional discussion in the Theos Discord on this topic here: https://discord.com/channels/811490080278839327/811494949849661490/1332595828098994186