Load talismanrc the same way for all modes #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
TalismanRC represents the version-controlled configurations talisman should consider when running. It is not responsible for distinguishing between different ways talisman can be invoked. Authored-by: Owen Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify (remove) logic that loads the TalismanRC struct from a .talismanrc file in different ways to account for different file ignore behavior when scanning history vs scanning HEAD or a single changeset. Instead, encapsulate this logic in the IgnoreEvaluator.