chore(android): forward --sdk in module build process #14112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Sep 14, 2024
…m-sdk into androidModuleBuild
cb1kenobi
approved these changes
Sep 14, 2024
hansemannn
pushed a commit
that referenced
this pull request
Sep 16, 2024
* chore(android): forward --sdk in module build process * optimize code
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the gradle8 PR I saw that inside a module when I run
ti build -p android --sdk 12.6.0it was building the module with 12.6.0 but the example app was still starting with12.4.0.GA.This PR will forward the
--sdkparameter and it won't crash withUnsupported Class File Major Version 61errors (module is build with java 17 but then run with java 11)Testing:
ti build -p android -l trace --sdk 12.6.0should show:after building the module ZIP.
android/cli/commands/_buildModule.jsto 12.4.0.GA and build the module again:ti build -p android -l trace(no custom SDK, it should take the default SDK) should show: