Sql server count big #1501
Merged
Sql server count big #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update SQLite snap (tidyverse#1563)
update from main
hadley
reviewed
Aug 14, 2025
| sql_variant( | ||
| mssql_scalar, | ||
| sql_translator(.parent = base_odbc_agg, | ||
| n = function() sql("COUNT_BIG(*)"), |
There was a problem hiding this comment.
Could you please include a comment with a link to the docs?
There was a problem hiding this comment.
Sure, now added!
hadley
reviewed
Aug 19, 2025
Co-authored-by: Hadley Wickham <[email protected]>
hadley
reviewed
Aug 19, 2025
| FROM `df` | ||
| ORDER BY `y` | ||
|
|
||
| # count_big |
There was a problem hiding this comment.
Where did these snapshots come from? I don't see a corresponding test.
There was a problem hiding this comment.
Sorry, not sure how that happened. Have now added test and updated snapshots
hadley
reviewed
Aug 19, 2025
tests/testthat/test-backend-mssql.R
Outdated
| test_that("count_big", { | ||
| mf <- lazy_frame(x = c(1:5), y = c(rep("A", 5)), con = simulate_mssql()) | ||
| expect_snapshot(count(mf)) | ||
| expect_snapshot(tally(mf)) |
There was a problem hiding this comment.
I think one snapshot test is adequate here
There was a problem hiding this comment.
Makes sense. Have removed the second one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use COUNT_BIG instead of COUNT for sql server so as to avoid overflow error for very large tables #1498