-
Notifications
You must be signed in to change notification settings - Fork 185
Sql server count big #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hadley
merged 12 commits into
tidyverse:main
from
oxford-pharmacoepi:sql_server_count_big
Sep 3, 2025
Merged
Sql server count big #1501
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0313c68
use big_count on sql server
edward-burn 3936207
typo
edward-burn 829a9c6
update tests
edward-burn 7c4edde
update news
edward-burn 3e2679b
Merge pull request #2 from tidyverse/main
catalamarti 65b1826
Merge branch 'sql_server_count_big' into main
catalamarti b517341
Merge pull request #3 from oxford-pharmacoepi/main
catalamarti dc588f5
Merge branch 'tidyverse:main' into sql_server_count_big
edward-burn 7cef8f1
add comment with link to the docs
edward-burn acf63fd
Update R/backend-mssql.R
edward-burn d329206
update snapshot test
edward-burn cc271f0
remove one snapshot test
edward-burn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -497,6 +497,38 @@ | |
| FROM `df` | ||
| ORDER BY `y` | ||
|
|
||
| # count_big | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where did these snapshots come from? I don't see a corresponding test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, not sure how that happened. Have now added test and updated snapshots |
||
|
|
||
| Code | ||
| dplyr::count(mf) | ||
| Output | ||
| <SQL> | ||
| SELECT COUNT_BIG(*) AS `n` | ||
| FROM `df` | ||
|
|
||
| --- | ||
|
|
||
| Code | ||
| dplyr::tally(mf) | ||
| Output | ||
| <SQL> | ||
| SELECT COUNT_BIG(*) AS `n` | ||
| FROM `df` | ||
|
|
||
| # can copy_to() and compute() with temporary tables (#438) | ||
|
|
||
| Code | ||
| db <- copy_to(con, df, name = unique_table_name(), temporary = TRUE) | ||
| Message | ||
| Created a temporary table named #dbplyr_{tmp} | ||
|
|
||
| --- | ||
|
|
||
| Code | ||
| db2 <- db %>% mutate(y = x + 1) %>% compute() | ||
| Message | ||
| Created a temporary table named #dbplyr_{tmp} | ||
|
|
||
| # add prefix to temporary table | ||
|
|
||
| Code | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include a comment with a link to the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, now added!