Skip to content

feat(traffic_light*): cherry-pick for new tlr #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 35 commits into
base: beta/v0.41
Choose a base branch
from

Conversation

MasatoSaeki
Copy link

@MasatoSaeki MasatoSaeki commented May 26, 2025

Description

Cherry-pick for new tlr. Including tlr refactor commit because it is easy to handle in perception ecu.

Reference list.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

vish0012 and others added 13 commits May 27, 2025 04:02
…ated ReadME file for parameters setting and deleted default parameter from the node.cpp file (autowarefoundation#9998)

* feat(traffic_light_occlusion_predictor): Created Schema file and updated ReadME file for parameters setting and deleted default parameter from the node.cpp file

Signed-off-by: vish0012 <[email protected]>

* style(pre-commit): autofix

* feat: modified the json schema and readme file as per comments

Signed-off-by: vish0012 <[email protected]>

---------

Signed-off-by: vish0012 <[email protected]>
Co-authored-by: Masato Saeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… schema, README and car and ped launcher (autowarefoundation#10048)

* feat(autoware_traffic_light_classifier):Add traffic light classifier schema and README

* add individual launcher

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix description

Signed-off-by: MasatoSaeki <[email protected]>

* fix README and source code

Signed-off-by: MasatoSaeki <[email protected]>

* separate schema in README

Signed-off-by: MasatoSaeki <[email protected]>

* fix README

Signed-off-by: MasatoSaeki <[email protected]>

* fix launcher

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: MasatoSaeki <[email protected]>
Co-authored-by: Masato Saeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…erger package (autowarefoundation#9748)

* feat: init traffic light signal merger

Signed-off-by: badai-nguyen <[email protected]>

* fix: add tl merger launch

Signed-off-by: badai-nguyen <[email protected]>

* fix: cmake lt merger

Signed-off-by: badai-nguyen <[email protected]>

* fix: remove unused depend

Signed-off-by: badai-nguyen <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* feat: add occlusion unknown classifier

Signed-off-by: badai-nguyen <[email protected]>

* chore: docs

Signed-off-by: badai-nguyen <[email protected]>

* fix: launcher

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* Revert "feat: add occlusion unknown classifier"

This reverts commit 9999d28.

* fix: launcher

Signed-off-by: badai-nguyen <[email protected]>

* refactor

Signed-off-by: badai-nguyen <[email protected]>

* chore: add maintainer

Signed-off-by: badai-nguyen <[email protected]>

* chore: docs update

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* refactor: rename package

Signed-off-by: badai-nguyen <[email protected]>

* fix: typo

Signed-off-by: badai-nguyen <[email protected]>

* change output topic name

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Masato Saeki <[email protected]>
Co-authored-by: MasatoSaeki <[email protected]>
autowarefoundation#9721)

* feat: add traffic light selector node

Signed-off-by: badai-nguyen <[email protected]>

feat: add traffic ligth selector node

Signed-off-by: badai-nguyen <[email protected]>

* fix: add check expect roi iou

Signed-off-by: badai-nguyen <[email protected]>

* fix: tl selector

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch file

Signed-off-by: badai-nguyen <[email protected]>

* fix: update matching score

Signed-off-by: badai-nguyen <[email protected]>

* fix: calc sum IOU for whole shifted image

Signed-off-by: badai-nguyen <[email protected]>

* fix: check inside rough roi

Signed-off-by: badai-nguyen <[email protected]>

* fix: check inside function

Signed-off-by: badai-nguyen <[email protected]>

* feat: add max_iou_threshold

Signed-off-by: badai-nguyen <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* docs: add readme

Signed-off-by: badai-nguyen <[email protected]>

* refactor: launch file

Signed-off-by: badai-nguyen <[email protected]>

* docs: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* docs

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* refactor

Signed-off-by: badai-nguyen <[email protected]>

* fix: add unknown in selector

Signed-off-by: badai-nguyen <[email protected]>

* fix: change to GenIOU

Signed-off-by: badai-nguyen <[email protected]>

* feat: add debug topic

Signed-off-by: badai-nguyen <[email protected]>

* fix: add maintainer

Signed-off-by: badai-nguyen <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* fix:cmake

Signed-off-by: badai-nguyen <[email protected]>

* fix: move param to yaml file

Signed-off-by: badai-nguyen <[email protected]>

* fix: typo

Signed-off-by: badai-nguyen <[email protected]>

* fix: add schema

Signed-off-by: badai-nguyen <[email protected]>

* fix

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: Masato Saeki <[email protected]>
Co-authored-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…for autoware_traffic_light_arbiter (autowarefoundation#10100)

* Added schema and related files for autoware_traffic_light_arbiter

* Added traffic_light_arbiter.schema.json

* style(pre-commit): autofix

* fix

Signed-off-by: MasatoSaeki <[email protected]>

* for perform ci

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: MasatoSaeki <[email protected]>
…lter (autowarefoundation#10089)

* add mutex

Signed-off-by: MasatoSaeki <[email protected]>

* change message filter

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…pdated the readme file and deleted the default parameter in node files code (autowarefoundation#10106)

* feat(autoware_traffic_light_fine_detector): Created the schema file, updated the readme file and deleted the default parameter in node files code

Signed-off-by: vish0012 <[email protected]>

* style(pre-commit): autofix

* fix declare_parameter

Signed-off-by: MasatoSaeki <[email protected]>

* chore

Signed-off-by: MasatoSaeki <[email protected]>

* change launch file

Signed-off-by: MasatoSaeki <[email protected]>

* change type

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix definition name

Signed-off-by: MasatoSaeki <[email protected]>

* run build

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: vish0012 <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: MasatoSaeki <[email protected]>
…ile,updated the readme file and deleted the default parameter in node files code (autowarefoundation#10107)

* feat(autoware_traffic_light_map_based_detector): Created the schema file,updated the readme file and deleted the default parameter in node files code

Signed-off-by: vish0012 <[email protected]>

* style(pre-commit): autofix

* move params from launch to param

Signed-off-by: MasatoSaeki <[email protected]>

* chore

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: vish0012 <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: MasatoSaeki <[email protected]>
…autowarefoundation#10141)

* build(autoware_traffic_light_selector): fix missing sophus dependency

Signed-off-by: Esteve Fernandez <[email protected]>

* fix missing cgal dependency

Signed-off-by: Esteve Fernandez <[email protected]>

---------

Signed-off-by: Esteve Fernandez <[email protected]>
…utowarefoundation#9731)

* feat: add traffic_light_detector launch

Signed-off-by: badai-nguyen <[email protected]>

fix: tier4 perception launch

Signed-off-by: badai-nguyen <[email protected]>

fix: add multi tlr detector launch

Signed-off-by: badai-nguyen <[email protected]>

fix: tier4 launch

Signed-off-by: badai-nguyen <[email protected]>

fix: tl detector launch

Signed-off-by: badai-nguyen <[email protected]>

fix: data director

Signed-off-by: badai-nguyen <[email protected]>

fix: precision int8

Signed-off-by: badai-nguyen <[email protected]>

chore: revert to fp16

Signed-off-by: badai-nguyen <[email protected]>

feat: remove occlusion and add car ped classification merger

Signed-off-by: badai-nguyen <[email protected]>

fix: launch for multi camera

Signed-off-by: badai-nguyen <[email protected]>

chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

fix: update matching score

Signed-off-by: badai-nguyen <[email protected]>

feat: add max_iou_threshold

Signed-off-by: badai-nguyen <[email protected]>

feat: add occlusion unknown classifier

Signed-off-by: badai-nguyen <[email protected]>

* fix: tl detector launch

Signed-off-by: badai-nguyen <[email protected]>

* refactor: traffic_light_launch.xml

Signed-off-by: badai-nguyen <[email protected]>

* fix: remove tl fine detector

Signed-off-by: badai-nguyen <[email protected]>

* fix: refactor

Signed-off-by: badai-nguyen <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* fix: cspelling check

Signed-off-by: badai-nguyen <[email protected]>

* fix: error after rename package

Signed-off-by: badai-nguyen <[email protected]>

* fix: default tl model name

Signed-off-by: badai-nguyen <[email protected]>

* fix: new tlr for multi cameras

Signed-off-by: badai-nguyen <[email protected]>

* modify args

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* refactor

Signed-off-by: MasatoSaeki <[email protected]>

* add category_merger to container

Signed-off-by: MasatoSaeki <[email protected]>

* fix args

Signed-off-by: MasatoSaeki <[email protected]>

* run pre-commit

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: Masato Saeki <[email protected]>
Co-authored-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fundamental change

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

* fix params and modify some packages

Signed-off-by: MasatoSaeki <[email protected]>

* pre-commit

Signed-off-by: MasatoSaeki <[email protected]>

* fix

Signed-off-by: MasatoSaeki <[email protected]>

* fix spell check

Signed-off-by: MasatoSaeki <[email protected]>

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

* integrate model and label path

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* for pre-commit

Signed-off-by: MasatoSaeki <[email protected]>

* run pre-commit

Signed-off-by: MasatoSaeki <[email protected]>

* for awsim

Signed-off-by: MasatoSaeki <[email protected]>

* for simulatior

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix grammer in launcher

Signed-off-by: MasatoSaeki <[email protected]>

* add schema for yolox_tlr

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* fix file name

Signed-off-by: MasatoSaeki <[email protected]>

* fix

Signed-off-by: MasatoSaeki <[email protected]>

* rename

Signed-off-by: MasatoSaeki <[email protected]>

* modify arg name  to

Signed-off-by: MasatoSaeki <[email protected]>

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

* change param name

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

* chore

Signed-off-by: MasatoSaeki <[email protected]>

---------

Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shintaro Tomie <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
MasatoSaeki and others added 4 commits May 27, 2025 12:43
…t test (autowarefoundation#10352) without autowarefoundation#10191

* refactor and test

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

Signed-off-by: MasatoSaeki <[email protected]>

* add dependency

Signed-off-by: MasatoSaeki <[email protected]>

* unnecessary dependency

Signed-off-by: MasatoSaeki <[email protected]>

* chore

Signed-off-by: MasatoSaeki <[email protected]>

* fix typo

Signed-off-by: MasatoSaeki <[email protected]>

* remove change in category_merger

Signed-off-by: MasatoSaeki <[email protected]>

* chnage var name

Signed-off-by: MasatoSaeki <[email protected]>

* add validation shiftRoi

Signed-off-by: MasatoSaeki <[email protected]>

* add new matching algo

Signed-off-by: MasatoSaeki <[email protected]>

* modify unittest

Signed-off-by: MasatoSaeki <[email protected]>

* remove unnecessary file

Signed-off-by: MasatoSaeki <[email protected]>

* change type from uint8_t to int64_t

Signed-off-by: MasatoSaeki <[email protected]>

* change  variable name in looping

Co-authored-by: badai nguyen  <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>

* use move instead of copy

Co-authored-by: badai nguyen  <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>

* change variable name in utils

Signed-off-by: MasatoSaeki <[email protected]>

* apply  header file

Signed-off-by: MasatoSaeki <[email protected]>

* to pass cppcheck

Signed-off-by: MasatoSaeki <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: badai nguyen <[email protected]>
@MasatoSaeki MasatoSaeki force-pushed the cherry-pick_to_v0.41/new_tlr branch from 0e258e8 to 1f13f78 Compare May 27, 2025 03:45
@MasatoSaeki MasatoSaeki marked this pull request as draft May 28, 2025 05:55
prakash-kannaiah and others added 4 commits May 30, 2025 09:06
)

Signed-off-by: prakash-kannaiah <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
…distance (autowarefoundation#10686)

* fix(scan_ground_segmentation): fix recheck effective range

Signed-off-by: badai-nguyen <[email protected]>

* feat: separate param for recheck region

Signed-off-by: badai-nguyen <[email protected]>

* chore: docs and test update

Signed-off-by: badai-nguyen <[email protected]>

* chore: docs

Signed-off-by: badai-nguyen <[email protected]>

* chore: rename param

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix schema

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
…on#10655)

* fix(roi_pointcloud_fusion): add remap output option

Signed-off-by: badai-nguyen <[email protected]>

* chore: docs update

Signed-off-by: badai-nguyen <[email protected]>

* fix: update refine cluster func

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix schema

Signed-off-by: badai-nguyen <[email protected]>

* fix: test utils

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen force-pushed the cherry-pick_to_v0.41/new_tlr branch from ec96e7e to 6bcfe09 Compare May 30, 2025 07:15
MasatoSaeki and others added 2 commits May 30, 2025 16:28
autowarefoundation#10738)

feat(obstacle_pointcloud_validator): add processing time ms for tracking perception performance

Signed-off-by: Jian Kang <[email protected]>
Co-authored-by: Jian Kang <[email protected]>
badai-nguyen and others added 12 commits June 2, 2025 22:05
… IDs (autowarefoundation#10609)

* fix(tier4_perception_launch): fix segmentation_pointcloud_fusion launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: remove duplicated line

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Copy link

sonarqubecloud bot commented Jun 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants