Skip to content

Develop/beta/v0.41 x2 pc sensing #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop/beta/v0.41-x2-pc
Choose a base branch
from

Conversation

manato
Copy link

@manato manato commented Jun 9, 2025

No description provided.

vividf and others added 8 commits June 6, 2025 20:05
feat: add diagnostic in pointcloud preprocessor
…cloud preprocessor (autowarefoundation#9454)

* feat: moved the cuda pointcloud preprocessor and organized from a personal repository

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: fixed incorrect links

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: fixed dead links pt2

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: fixed spelling errors

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: json schema fixes

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed comments and filled the fields

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: fixed the adapter for the case when the number of points in the pointcloud changes after the first iteration

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: used the cuda host allocators for aster host to device copies

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/docs/cuda-pointcloud-preprocessor.md

Co-authored-by: Max Schmeller <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor.cu

Co-authored-by: Manato Hirabayashi <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor.cu

Co-authored-by: Manato Hirabayashi <[email protected]>

* style(pre-commit): autofix

* Update sensing/autoware_cuda_pointcloud_preprocessor/docs/cuda-pointcloud-preprocessor.md

Co-authored-by: Max Schmeller <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/README.md

Co-authored-by: Max Schmeller <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/README.md

Co-authored-by: Max Schmeller <[email protected]>

* Update sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor.cu

Co-authored-by: Max Schmeller <[email protected]>

* style(pre-commit): autofix

* Update sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor.cu

Co-authored-by: Manato Hirabayashi <[email protected]>

* style(pre-commit): autofix

* Update sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor.cu

Co-authored-by: Manato Hirabayashi <[email protected]>

* style(pre-commit): autofix

* chore: fixed code compilation to reflect Hirabayashi-san's  memory pool proposal

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: generalized the number of crop boxes. For two at least, the new approach is actually faster

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: updated config, schema, and handled the null case in a specialized way

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: moving the pointcloud organization into gpu

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: reimplemented the organized pointcloud adapter in cuda. the only bottleneck is the H->D copy

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed redundant ternay operator

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added a temporary memory check. the check will be unified in a later PR

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: refactored the structure to avoid large files

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: updated the copyright year

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: fixed a bug in the undistortion kernel setup. validated it comparing it with the baseline

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused packages

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed mentions of the removed adapter

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: fixed missing autoware prefix

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: missing assignment in else branch

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added cuda/nvcc debug flags on debug builds

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: refactored parameters for the undistortion settings

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused headers

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: changed default crop box to no filtering at all

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: added missing restrict keyword

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: spells

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed default destructor

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ocd activated (spelling)

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: fixed the schema

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: improved readibility

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added dummy crop box

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added new repositories to ansible

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: CI/CD

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: more CI/CD

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: mode CI/CD. some linters are conflicting

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* style(pre-commit): autofix

* chore: ignoring uncrustify

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ignoring more uncrustify

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: missed one more uncrustify exception

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added meta dep

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Co-authored-by: Max Schmeller <[email protected]>
Co-authored-by: Manato Hirabayashi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Amadeusz Szymko <[email protected]>
…llback with polling subscriber (autowarefoundation#10509)

* feat(cuda_pointcloud_preprocessor): replace subscriptions with InterProcessPollingSubscriber for twist and IMU data

Signed-off-by: Takahisa.Ishikawa <[email protected]>

* fix(cuda_pointcloud_preprocessor): remove unused twist_queue_ variable

Signed-off-by: Takahisa.Ishikawa <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Takahisa.Ishikawa <[email protected]>
Co-authored-by: Takahisa.Ishikawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…towarefoundation#10523)

* Synchronize CUDA stream by blocking instead of spin

* Use blocking-sync in BEVFusion

* Call cudaSetDeviceFlags in tensorrt_common
…utowarefoundation#10748)

* fix(cuda_pointcloud_preprocessor): ensure ordered twist/imu queues

Signed-off-by: Max SCHMELLER <[email protected]>

* chore: satisfy uncrustify

Signed-off-by: Max SCHMELLER <[email protected]>

* chore: uncrustify and clang-format conflict, disable uncrustify for statement

Signed-off-by: Max SCHMELLER <[email protected]>

---------

Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
Co-authored-by: Max SCHMELLER <[email protected]>
…st-v4.2.0 autoware_cuda_dependency_meta

Signed-off-by: Max SCHMELLER <[email protected]>
Copy link

sonarqubecloud bot commented Jun 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants