Keep improving CI #292
Merged
Keep improving CI #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BryanQuigley
commented
Jan 29, 2025
BryanQuigley
commented
This shouldn't have been nessary for paths but seems fine.
lydiascarf
approved these changes
Feb 3, 2025
Collaborator
lydiascarf
left a comment
lydiascarf
left a comment
There was a problem hiding this comment.
lgtm! i like the linter running only on changes by default, and it ran as expected when i tested it.
i tested against odp as well and it was mostly good! the only thing was we have this line in our megalinter config:
BASH_SHFMT_ARGUMENTS: "-i 4"
and cspell didn't like "SHFMT". this env is telling the bash linter to use 4 spaces instead of tabs, which i like. maybe we should add that in here as well and address the cspell error before merging
this includes spellcheck for both other files and markdown updated lint script that has more options - including formatting enabled markdown link checker as the first pass on making sure links work update CI to only activate on changed files
BryanQuigley
force-pushed
the
spellcheck
branch
from
1ce3190 to
73c06b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.