Update GitHub Actions artifact steps to v4 #8
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| needs: [linux, windows, macos, sdist] | ||
| steps: | ||
| - uses: actions/download-artifact@v3 | ||
| - uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
Bug: Artifact Path Change Breaks Upload
The actions/download-artifact@v4 update now places artifacts into a wheels/ subdirectory by default. This prevents the subsequent maturin upload command from finding the wheel files, as it expects them in the current directory.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| apt update -y && apt-get install -y libssl-dev openssl pkg-config | ||
| fi |
There was a problem hiding this comment.
The upgrade to actions/upload-artifact@v4 changes behavior: v4 no longer appends to an existing artifact and will fail when another job tries to upload with the same name. All matrix jobs (linux, windows, macos) plus sdist still publish to an artifact named wheels, so after the first successful upload, the next job will error out with “Artifact with the name wheels already exists for the run.” To keep aggregating wheels from multiple jobs, each upload needs a unique name (e.g. include ${{ matrix.target }}) and the release job should download them via a pattern with merge: true.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f4b8328250833184a319960d669dba