Skip to content

Update GitHub Actions artifact steps to v4 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiwilliam merged 1 commit into from
Oct 19, 2025
Merged

Update GitHub Actions artifact steps to v4 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
apt update -y && apt-get install -y libssl-dev openssl pkg-config
fi
Comment on lines 37 to 38
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid reusing artifact name after switching to v4 actions

The upgrade to actions/upload-artifact@v4 changes behavior: v4 no longer appends to an existing artifact and will fail when another job tries to upload with the same name. All matrix jobs (linux, windows, macos) plus sdist still publish to an artifact named wheels, so after the first successful upload, the next job will error out with “Artifact with the name wheels already exists for the run.” To keep aggregating wheels from multiple jobs, each upload needs a unique name (e.g. include ${{ matrix.target }}) and the release job should download them via a pattern with merge: true.

Useful? React with 👍 / 👎.

- name: Upload wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
path: dist
Expand All @@ -60,7 +60,7 @@ jobs:
args: --release --out dist --find-interpreter
sccache: "true"
- name: Upload wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
path: dist
Expand All @@ -82,7 +82,7 @@ jobs:
args: --release --out dist --find-interpreter
sccache: "true"
- name: Upload wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
path: dist
Expand All @@ -97,7 +97,7 @@ jobs:
command: sdist
args: --out dist
- name: Upload sdist
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
path: dist
Expand All @@ -107,7 +107,7 @@ jobs:
runs-on: ubuntu-latest
needs: [linux, windows, macos, sdist]
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
Copy link

@cursor cursor bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Artifact Path Change Breaks Upload

The actions/download-artifact@v4 update now places artifacts into a wheels/ subdirectory by default. This prevents the subsequent maturin upload command from finding the wheel files, as it expects them in the current directory.

Fix in Cursor Fix in Web

with:
name: wheels
- name: Publish to PyPI
Expand Down