Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new template doc property #9538

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jan 6, 2025

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Jan 6, 2025
Copy link
Member Author

CatsJuice commented Jan 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice changed the title temp feat(core): new template doc property Jan 6, 2025
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch from 5935bbf to 70fdcf3 Compare January 6, 2025 05:11
@CatsJuice CatsJuice marked this pull request as ready for review January 6, 2025 05:16
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (777eea1) to head (10196f6).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ges/frontend/core/src/modules/doc/services/docs.ts 0.00% 34 Missing ⚠️
...ages/frontend/core/src/modules/doc/entities/doc.ts 0.00% 3 Missing ⚠️
...s/frontend/core/src/modules/doc/entities/record.ts 0.00% 2 Missing ⚠️
...kages/frontend/core/src/modules/doc/stores/docs.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9538      +/-   ##
==========================================
+ Coverage   51.43%   52.79%   +1.36%     
==========================================
  Files        2158     2180      +22     
  Lines       97944    98617     +673     
  Branches    16646    16768     +122     
==========================================
+ Hits        50378    52066    +1688     
+ Misses      46313    45111    -1202     
- Partials     1253     1440     +187     
Flag Coverage Δ
server-test 77.83% <ø> (ø)
unittest 32.21% <2.43%> (+2.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch from a136e6d to f8bfa51 Compare January 8, 2025 02:48
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch 2 times, most recently from e484196 to 0905ead Compare January 8, 2025 07:16
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch 2 times, most recently from 3508787 to c1adaea Compare January 13, 2025 03:18
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch from d3ff9c6 to f4ead78 Compare January 13, 2025 08:21
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc branch from d82bf58 to 7cbd8ef Compare January 13, 2025 09:29
Copy link

graphite-app bot commented Jan 14, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants