Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): template doc setting ui #9658

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jan 13, 2025

close AF-2051, AF-2052

Copy link
Member Author

CatsJuice commented Jan 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Jan 13, 2025
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-store branch from d63564a to 882e9f6 Compare January 13, 2025 08:15
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-ui branch from 7a192c8 to d52d51b Compare January 13, 2025 08:15
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-store branch from 882e9f6 to c6c8293 Compare January 13, 2025 08:22
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-ui branch from d52d51b to 4dc0b28 Compare January 13, 2025 08:22
@CatsJuice CatsJuice marked this pull request as ready for review January 13, 2025 08:28
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-store branch from c6c8293 to bf3bd47 Compare January 13, 2025 08:58
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-ui branch from 4dc0b28 to c2e9efd Compare January 13, 2025 08:58
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-store branch from bf3bd47 to 355ac05 Compare January 13, 2025 09:29
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-ui branch from c2e9efd to dd31ea3 Compare January 13, 2025 09:29
Copy link

perfsee bot commented Jan 13, 2025

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …oc-setting-ui                 +/- ##
===================================================================
< Bundle              24.5 MB        25.1 MB     +569 kB(+2.32%)   
< Initial JS          10.3 MB        10.6 MB     +330 kB(+3.21%)   
< Initial CSS          213 kB         264 kB   +50.6 kB(+23.76%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   87             95                  +8   
< Chunks                   85             93                  +8   
= Packages                269            269                       
= Duplicates                4              4                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

Copy link

graphite-app bot commented Jan 14, 2025

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-store branch from bc6cb9e to 57b89b5 Compare January 14, 2025 02:11
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-doc-setting-ui branch from 580685f to af3ad4b Compare January 14, 2025 02:11
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (57b89b5) to head (af3ad4b).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ntend/core/src/modules/journal/services/journal.ts 0.00% 13 Missing ⚠️
.../modules/editor-setting/services/editor-setting.ts 0.00% 2 Missing ⚠️
...c/modules/template-doc/view/template-list-menu.tsx 60.00% 2 Missing ⚠️
.../core/src/modules/template-doc/entities/setting.ts 0.00% 1 Missing ⚠️
...end/core/src/modules/template-doc/store/setting.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9658      +/-   ##
==========================================
- Coverage   52.77%   52.77%   -0.01%     
==========================================
  Files        2180     2195      +15     
  Lines       98624    98771     +147     
  Branches    16771    16813      +42     
==========================================
+ Hits        52048    52124      +76     
- Misses      45136    45202      +66     
- Partials     1440     1445       +5     
Flag Coverage Δ
server-test 77.83% <ø> (+0.05%) ⬆️
unittest 32.22% <13.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from catsjuice/feat/template-doc-setting-store to canary January 14, 2025 02:35
@graphite-app graphite-app bot merged commit af3ad4b into canary Jan 14, 2025
61 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/template-doc-setting-ui branch January 14, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants