Skip to content

Conversation

@po4tion
Copy link
Collaborator

@po4tion po4tion commented May 11, 2025

Overview

fix #320
fix #318

2건의 이슈를 해결하는 PR입니다.

ㄴ/ㄹ 덧나는 현상을 처리하는 로직에 부가 조건을 추가하여 보완하였습니다.

부가 조건

대부분의 'ㄴ/ㄹ 첨가'는 [아, 어, 오, 우] 계열처럼 명확한 음절 경계가 생길 때 발생하므로, ㄴ/ㄹ이 되는 조건이지만, 다음 음절이 정확히 받침이 없는 "이"로 시작하는 경우에는 ㄴ/ㄹ이 덧나지 않도록 처리하였습니다.

#341 에서 ㄴ/ㄹ 로직을 수정하고 있기에, 해당 PR이 종료된 후에 현재 PR과 병합하여 추가적으로 수정하겠습니다.

image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@po4tion po4tion self-assigned this May 11, 2025
@po4tion po4tion requested a review from okinawaa as a code owner May 11, 2025 15:09
@po4tion po4tion added the bug Something isn't working label May 11, 2025
@po4tion po4tion requested a review from raon0211 as a code owner May 11, 2025 15:09
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2025

🦋 Changeset detected

Latest commit: 66d51a5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
es-hangul Ready Ready Preview Comment Sep 27, 2025 2:51am

okinawaa
okinawaa previously approved these changes Sep 27, 2025
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

@okinawaa okinawaa merged commit 4969bf6 into toss:main Sep 27, 2025
2 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ㄴ/ㄹ 덧남 working wrong on some words [Bug]: romanization issues with epenthetic "n"

2 participants