Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): update test to tracing from metrics equivalent #896

Closed
wants to merge 2 commits into from
Closed

chore(tests): update test to tracing from metrics equivalent #896

wants to merge 2 commits into from

Conversation

davhdavh
Copy link
Contributor

@davhdavh davhdavh commented Jul 27, 2023 •
edited by mloiseleur
Loading

What does this PR do?

Fix a test on openTelemetry for Traefik v3

Motivation

The test is incorrect.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur
Copy link
Contributor

@davhdavh The tests are failing.

@mloiseleur mloiseleur changed the title Forgot to update test to tracing from metrics equivalent chore(tests): update test to tracing from metrics equivalent Jul 27, 2023
mloiseleur

This comment was marked as outdated.

Sign in to view

@mloiseleur
Copy link
Contributor

@davhdavh I fixed also this PR with b3bc322.

Let me know if you have a better idea or wants to tackle it differently.

@davhdavh davhdavh closed this Jul 31, 2023
@davhdavh davhdavh deleted the patch-2 branch July 31, 2023 17:09
@mloiseleur mloiseleur mentioned this pull request Aug 1, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

Assignees
No one assigned
Labels
contributor/waiting-for-corrections kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davhdavh @mloiseleur