Prevent accidental lockouts #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
force-pushed
the
prevent-lockout
branch
2 times, most recently
from
403aa29 to
19c5150
Compare
Member
Author
|
Example, if you now accidentally remove something important (like say the |
squell
force-pushed
the
prevent-lockout
branch
2 times, most recently
from
bea39d9 to
cb30e76
Compare
rnijveld
approved these changes
Mar 28, 2025
also removes an annoying bug in the visudo handler, which would print 'Ok("\n")' a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1044
Also fixes a bug in
visudowhere it would not consume the newline that was entered in a prompt.I've also tried to reformat the "redo until the sudoers file is acceptable" loop to make the control flow a little more clear.
Can be reviewed commit-by-commit.
I expect a6ccf9f to be a controversial commit and I can live without it.