Convert byte array to string for logging in ProxyResponse #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneonestar
reviewed
Dec 24, 2024
gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyResponseHandler.java
Outdated
Show resolved
Hide resolved
willmostly
reviewed
Jan 7, 2025
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
Looks good % @oneonestar 's comment
andythsu
force-pushed
the
fix_log
branch
3 times, most recently
from
8a7b688 to
601ef5b
Compare
willmostly
requested changes
Jan 14, 2025
gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyResponseHandler.java
Outdated
Show resolved
Hide resolved
willmostly
requested changes
Jan 15, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/config/ProxyResponseConfiguration.java
Show resolved
Hide resolved
andythsu
force-pushed
the
fix_log
branch
2 times, most recently
from
f864013 to
a99357f
Compare
willmostly
approved these changes
Jan 21, 2025
ebyhr
reviewed
Jan 22, 2025
| private final List<String> statementPaths; | ||
| private final boolean includeClusterInfoInResponse; | ||
| private final TrinoRequestUser.TrinoRequestUserProvider trinoRequestUserProvider; | ||
| private final ProxyResponseConfiguration proxyResponseConfiguration; |
Member
There was a problem hiding this comment.
Please avoid putting mutable objects in fields.
| { | ||
| try { | ||
| return new ProxyResponse(response.getStatusCode(), response.getHeaders(), response.getInputStream().readAllBytes()); | ||
| return new ProxyResponse(response.getStatusCode(), response.getHeaders(), new String(response.getInputStream().readNBytes((int) responseSize.toBytes()), StandardCharsets.UTF_8)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
byte[]cannot get logged. Changing it to actualStringtype for loggingAdditional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: