Fix issue #229: fix db handling on verification of SigningTable in dkimf_config_load #230
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in dkimf_config_load - check error on calling dkimf_db_walk() - fix request parameter for "signer" field in SigningTable
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Oct 7, 2024
…e229-fix-signingtable-verification Fix issue trusteddomainproject#229: fix db handling on verification of SigningTable in dkimf_config_load - check error on calling dkimf_db_walk() - fix request parameter for "signer" field in SigningTable trusteddomainproject#230 trusteddomainproject#229
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Oct 7, 2024
|
This causes opendkim/tests/t-sign-rs-tables-bad failure, because with this change opendkim fail to start due to the bad key entry pointed by signingtable, checked on dkimf_config_load. I'll fix it. |
SigningTable is now checked for each entries so that their corresponding key entry exists in valid form as well as its existence in KeyTable on loading config file on start up, if the type of SigningTable dataset supports dkimf_db_walk. However we need to use bad format entry in KeyTable, to perform the test, so we use 'refile' dataset type for SigningTable to avoid the check.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Dec 23, 2024
…i/issue229-fix-signingtable-verification
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for fixing the issue #229