Support ed25519 in opendkim tools, fix orphaned opendkim-genzone bug #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on trusteddomainproject#162 This should be merged after PR trusteddomainproject#162, Upgrade to OpenSSL 3". 1. opendkim-genkey: require openssl >= 1.1.1 for ed25519 instead of == 1.1.1. 2. opendkim-testkey: Add options 1, 2, and e to create an rsa-sha1, rsa-sha256, or ed25519 signature, respectively. Rsa-sha256 is the default. Previously the tool could only create rsa-sha1 signatures. 3. opendkim-genzone: Debian's opendkim includes nsupdate_output.patch which was added long ago for Debian bug 849540: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849540 The patch originally came from a bug reported against 2.10.3 in the opendkim sourceforge bug database: https://sourceforge.net/p/opendkim/feature-requests/200 Somehow that sourceforge bug and fix didn't make it to opendkim github. That patch fixes nsupdate output formatting and adds a key usage option. This patch does that and also adds support for ed25519 keys.
|
Can someone look into this? Support for Ed25519 would be nice. For alternatives, consider rspamd which supports both RSA and Ed25519. It's also important that SHA256 support is added. Edit: with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #162
This should be merged after PR #162, "Upgrade to OpenSSL 3".
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849540.
The patch originally came from a bug reported against 2.10.3 in the opendkim sourceforge bug database:
https://sourceforge.net/p/opendkim/feature-requests/200
Somehow that sourceforge bug report and fix didn't make it to opendkim github. That patch fixes nsupdate output formatting and adds a key usage option. This patch does that and also adds support for ed25519 keys.