Skip to content

fix: package-json.lock files are generated even if npm is not the package manager #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 8, 2025
Merged

fix: package-json.lock files are generated even if npm is not the package manager #114

merged 5 commits into from
Apr 8, 2025

Conversation

ruromero
Copy link
Collaborator

@ruromero ruromero commented Apr 7, 2025 •
edited
Loading

Description

This fix #113
I also took the opportunity to:

  • make system calls using an array of strings
  • remove unused and commented code
  • Add TODOs for future work
  • Move some hardcoded strings into constants
  • Refactor the provider to be instantiated with the path
  • Use Path instead of Paths
  • Use a common functionality for accessing Environment variables and System properties: Prefer properties over EnvVars
  • Implement componentAnalysis with a file path

Related issue (if any): fixes #issue_number_goes_here

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Strum355
Strum355 reviewed Apr 7, 2025
View reviewed changes
Strum355
Strum355 reviewed Apr 7, 2025
View reviewed changes
@ruromero ruromero changed the title Carlos pkg lock fix: package-json.lock files are generated even if npm is not the package manager Apr 8, 2025
@ruromero ruromero force-pushed the carlos-pkg-lock branch 12 times, most recently from cdb4942 to bfab773 Compare April 8, 2025 10:42
@ruromero
fix: cleanup and refactor
ef0ba31 
Signed-off-by: Ruben Romero Montes <[email protected]>
@ruromero ruromero force-pushed the carlos-pkg-lock branch 2 times, most recently from f233f23 to 2af399e Compare April 8, 2025 13:32
@ruromero
fix: update module-info
e24ab22 
Signed-off-by: Ruben Romero Montes <[email protected]>
@ruromero ruromero force-pushed the carlos-pkg-lock branch 2 times, most recently from f5b1945 to f057b73 Compare April 8, 2025 15:37
@ruromero
refactor: avoid mocking system.getenv
7f3836c 
Signed-off-by: Ruben Romero Montes <[email protected]>
@ruromero ruromero enabled auto-merge (squash) April 8, 2025 16:06
Strum355
Strum355 reviewed Apr 8, 2025
View reviewed changes
Strum355
Strum355 reviewed Apr 8, 2025
View reviewed changes
Strum355
Strum355 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@Strum355 Strum355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small non-blocking comments

@ruromero ruromero disabled auto-merge April 8, 2025 19:20
@ruromero ruromero merged commit 5b372df into trustification:main Apr 8, 2025
2 checks passed
@ruromero ruromero deleted the carlos-pkg-lock branch April 8, 2025 19:20
@ruromero ruromero mentioned this pull request Apr 8, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strum355 Strum355 Strum355 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package-lock.json files are generated if they don't exist
3 participants
@ruromero @Strum355 @carlosthe19916