Migrate Tezos to Rust #4434
Open
Migrate Tezos to Rust #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: - 14.07 MB
+ 14.13 MB +67 KB➡️ aarch64-apple-ios-sim: - 14.07 MB
+ 14.14 MB +67 KB➡️ aarch64-linux-android: - 18.56 MB
+ 18.67 MB +109 KB➡️ armv7-linux-androideabi: - 15.53 MB
+ 15.60 MB +76 KB➡️ wasm32-unknown-emscripten: - 13.23 MB
+ 13.29 MB +65 KB |
Comment on lines
38
to
45
| pub fn base58_to_hex(input: &str, prefix_length: usize) -> String { | ||
| let decoded = match decode_check(input, Alphabet::Bitcoin) { | ||
| Ok(d) => d, | ||
| Err(_) => return String::new(), | ||
| }; | ||
|
|
||
| if decoded.len() < prefix_length { | ||
| return String::new(); |
There was a problem hiding this comment.
Shouldn't return an error instead?
Comment on lines
78
to
79
| let decoded = | ||
| decode_check(private_key, Alphabet::Bitcoin).map_err(|_| KeyPairError::InvalidSecretKey)?; |
There was a problem hiding this comment.
Please wrap to Zeroized
rust/chains/tw_tezos/src/compiler.rs
Outdated
| .map_err(|_| SigningErrorType::Error_internal)?; | ||
|
|
||
| let mut watermarked_data = Vec::new(); | ||
| watermarked_data.push(0x03); |
| // Optional modules: | ||
| type JsonSigner = NoJsonSigner; | ||
| type PlanBuilder = NoPlanBuilder; | ||
| type MessageSigner = NoMessageSigner; |
There was a problem hiding this comment.
Here we need to add a TezosMessageSigner module to be able to handle TWMessageSigner requests
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates Tezos from C++ to Rust.
How to test
Run tests
Types of changes
Refactor
Checklist
If you're adding a new blockchain