Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsql: error on invalid frame_no on wal read #1872

Merged
merged 1 commit into from
Dec 10, 2024
Merged

libsql: error on invalid frame_no on wal read #1872

merged 1 commit into from
Dec 10, 2024

Conversation

LucioFranco
Copy link
Contributor

This prevents a potential panic that can happen in our ffi code when it expects a NonZero value but the input type into the unsafe function is a u32, meaning the compiler will not enforce the value and will result in a panic. This changes it so that when the code is called via the sys crate safe code it will return a sqlite failure.

Closes #1868

This prevents a potential panic that can happen in our ffi code when it
expects a NonZero value but the input type into the unsafe function is a
u32, meaning the compiler will not enforce the value and will result in
a panic. This changes it so that when the code is called via the sys
crate safe code it will return a sqlite failure.

Closes #1868
@penberg penberg added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 3f5ccae Dec 10, 2024
19 checks passed
@penberg penberg deleted the lucio/1868 branch December 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled panic in libsql-sys wal ffi
2 participants