Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsql: error on invalid frame_no on wal read #1872

Merged
merged 1 commit into from
Dec 10, 2024
Merged

libsql: error on invalid frame_no on wal read #1872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libsql/src/local/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,13 @@ impl Connection {
// and more efficient buffer usage for extracting wal frames and spliting them off.
let mut buf = bytes::BytesMut::with_capacity(frame_size);

if frame_no == 0 {
return Err(errors::Error::SqliteFailure(
1,
"frame_no must be non-zero".to_string(),
));
}

let rc = unsafe {
libsql_sys::ffi::libsql_wal_get_frame(
self.handle(),
Expand Down
Loading