Kill unwrap() before it kills us #3992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
requested review from
PThorpe92,
jussisaurio and
pereman2
as code owners
penberg
force-pushed
the
kill-unwrap
branch
2 times, most recently
from
195cf37 to
6a5767e
Compare
penberg
force-pushed
the
kill-unwrap
branch
2 times, most recently
from
46caa00 to
07990df
Compare
penberg
force-pushed
the
kill-unwrap
branch
2 times, most recently
from
4eb070f to
59add10
Compare
penberg
added a commit
that referenced
this pull request
Nov 21, 2025
As preparation for #3992 that actually enforces no unwraps, remove them from extensions. Reviewed-by: Preston Thorpe <[email protected]> Closes #4000
penberg
force-pushed
the
kill-unwrap
branch
2 times, most recently
from
6326417 to
47370f2
Compare
Eliminates few unwrap() calls.
Instead of using registers_to_ref_values(), let's just pass a slice to vector functions to eliminate bunch of unwraps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with unwrap() is that it leaves no trace if the programmer actually thought it's safe to use. Therefore, let's prefer expect() because at least it forces the programmer to leave a note. While at it, eliminate some uses of unwrap() with error handling.