fix Issue #4339: remove Panic on out of bounds access in Row::get_value() #4357
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
jussisaurio
reviewed
Dec 26, 2025
jussisaurio
reviewed
Dec 26, 2025
Author
|
is the bench test making a request that times out a known issue? |
Collaborator
github has been really unreliable lately |
jussisaurio
approved these changes
Dec 26, 2025
Collaborator
|
Will merge as soon as conflicts resolved 👍 looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
Row::get_value()andRow::get<T>for the Rust bindings, the underlyingVecthat holds the queried values is accessed by[]such that out of bounds accesses cause a panic. Changed this to.get()on theVecsuch that we can return anErrinstead of panicking. Also added a test to verify this behavior (not sure if I had to, if this is unnecessary, I can remove).Motivation and context
Issue #4339 said that this was behavior. Seemingly, current behavior is not in line with
rustqlite::row::Row::get. It is also intuitively the case that methods should not panic on OOB access, especially not without documentation. Noticed that the same behavior happens inlibsql::Row::get_valueandlibsql::Row::get<T>. I will submit same PR there as well.Description of AI Usage
Claude code wrote the test.