Skip to content

fix Issue #4339: remove Panic on out of bounds access in Row::get_value() #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adhi-thirumala wants to merge 5 commits into
base: main
Choose a base branch
from
+35 −4
Open

fix Issue #4339: remove Panic on out of bounds access in Row::get_value() #4357

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbf8525
switched from [] access on vec to .get() to return Err on OOB access
adhi-thirumala Dec 26, 2025
6c2b293
renamed value to val and index to idx to keep common naming scheme
adhi-thirumala Dec 26, 2025
f529f69
added test to make sure out of bounds get on row value returns Err
adhi-thirumala Dec 26, 2025
5ca9606
changed ok_or to ok_or_else to prevent needless allocation of Err
adhi-thirumala Dec 26, 2025
3acacef
added empty closure for ok_or_else
adhi-thirumala Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions bindings/rust/src/rows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,12 @@ unsafe impl Send for Row {}
unsafe impl Sync for Row {}

impl Row {
pub fn get_value(&self, index: usize) -> Result<Value> {
let value = &self.values[index];
match value {
pub fn get_value(&self, idx: usize) -> Result<Value> {
let val = &self
.values
.get(idx)
.ok_or(Error::SqlExecutionFailure("invalid row index".to_string()))?;
match val {
turso_core::Value::Integer(i) => Ok(Value::Integer(*i)),
turso_core::Value::Null => Ok(Value::Null),
turso_core::Value::Float(f) => Ok(Value::Real(*f)),
Expand All @@ -102,7 +105,10 @@ impl Row {
where
T: FromValue,
{
let val = &self.values[idx];
let val = self
.values
.get(idx)
.ok_or(Error::SqlExecutionFailure("invalid row index".to_string()))?;
T::from_sql(val.clone()).map_err(|err| Error::ConversionFailure(err.to_string()))
}

Expand Down
25 changes: 25 additions & 0 deletions bindings/rust/tests/integration_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,31 @@ async fn test_transaction_prepared_statement() {
assert_eq!(id, 1);
}

#[tokio::test]
async fn test_row_get_value_out_of_bounds() {
let db = Builder::new_local(":memory:").build().await.unwrap();
let conn = db.connect().unwrap();

conn.execute("CREATE TABLE t (x INTEGER)", ())
.await
.unwrap();
conn.execute("INSERT INTO t VALUES (1)", ()).await.unwrap();

let mut rows = conn.query("SELECT x FROM t", ()).await.unwrap();
let row = rows.next().await.unwrap().unwrap();

// Valid index works
assert!(row.get_value(0).is_ok());

// Out of bounds returns error instead of panicking
let result = row.get_value(999);
assert!(matches!(result, Err(Error::SqlExecutionFailure(_))));

// Also test get<T>() for OOB
let result: Result<i64, _> = row.get(999);
assert!(matches!(result, Err(Error::SqlExecutionFailure(_))));
}

// Test Connection clone
#[tokio::test]
async fn test_connection_clone() {
Expand Down
Loading