Optimized computations #1023
Merged
Optimized computations #1023
+258
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.dom.augmentation.d.ts
Contributor
|
tysm for working on this <3 |
| { | ||
| "category": "message", | ||
| "code": 6500, | ||
| "message": "The expected type comes from property 'onclick' which is declared here on type 'Partial<AttributesForElement<HTMLDivElement>>'", |
Contributor
There was a problem hiding this comment.
NOTE for me -- I think we can explode this out to list the actual available attributes by doing something like & {}
NullVoxPopuli
approved these changes
Nov 17, 2025
ijlee2
commented
Nov 17, 2025
Comment on lines
694
to
699
| ['HTMLBodyElement']: GlobalHTMLAttributes; | ||
| ['HTMLDataListElement']: GlobalHTMLAttributes; | ||
| ['HTMLHtmlElement']: GlobalHTMLAttributes; | ||
| ['HTMLPictureElement']: GlobalHTMLAttributes; | ||
| ['HTMLSpanElement']: GlobalHTMLAttributes; | ||
| ['HTMLTitleElement']: GlobalHTMLAttributes; |
Contributor
Author
There was a problem hiding this comment.
GlobalHTMLAttributes may not be the correct thing to use. For simplicity, I used it like the default value that we see for HTMLElement on line 693.
If there's a better Attributes type to use, I suggest making the change in a separate pull request.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Closes #1022.
GlintHtmlElementAttributesMap.HTMLElementandSVGElementto improve performance (runtime should be back to what it was for@glint/[email protected])GlintHtmlElementAttributesMap,GlintSvgElementAttributesMap,HTMLElementMap, andSVGElementMapto help with maintenance.