Skip to content

Optimized computations #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2025
+258 −198
Merged

Optimized computations #1023

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2814476
bugfix: Removed duplicate entries
ijlee2 Nov 17, 2025
f954eac
bugfix: Added missing entries
ijlee2 Nov 17, 2025
527ac38
refactor: Introduced divide-and-conquer
ijlee2 Nov 17, 2025
ebe25c6
refactor: Removed unnecessary computations
ijlee2 Nov 17, 2025
878b3f4
bugfix, refactor: Ensured that build-augmentations creates the new li…
ijlee2 Nov 17, 2025
317273b
bugfix, refactor: Ensured that build-elements creates the new elemen…
ijlee2 Nov 17, 2025
789e43e
chore: Ran build-augmentation and build-elements
ijlee2 Nov 17, 2025
e5d7122
chore: Updated assertions
ijlee2 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions packages/template/-private/dsl/elements.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,15 +638,12 @@ interface GlintHtmlElementAttributesMap {
['HTMLAreaElement']: HTMLAreaElementAttributes;
['HTMLAudioElement']: HTMLAudioElementAttributes;
['HTMLBaseElement']: HTMLBaseElementAttributes;
['HTMLQuoteElement']: HTMLQuoteElementAttributes;
['HTMLBRElement']: HTMLBRElementAttributes;
['HTMLButtonElement']: HTMLButtonElementAttributes;
['HTMLCanvasElement']: HTMLCanvasElementAttributes;
['HTMLTableCaptionElement']: HTMLTableCaptionElementAttributes;
['HTMLTableColElement']: HTMLTableColElementAttributes;
['HTMLTableColElement']: HTMLTableColElementAttributes;
['HTMLDataElement']: HTMLDataElementAttributes;
['HTMLModElement']: HTMLModElementAttributes;
['HTMLDetailsElement']: HTMLDetailsElementAttributes;
['HTMLDialogElement']: HTMLDialogElementAttributes;
['HTMLDivElement']: HTMLDivElementAttributes;
Expand All @@ -655,11 +652,6 @@ interface GlintHtmlElementAttributesMap {
['HTMLFieldSetElement']: HTMLFieldSetElementAttributes;
['HTMLFormElement']: HTMLFormElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadingElement']: HTMLHeadingElementAttributes;
['HTMLHeadElement']: HTMLHeadElementAttributes;
['HTMLHRElement']: HTMLHRElementAttributes;
['HTMLIFrameElement']: HTMLIFrameElementAttributes;
Expand Down Expand Up @@ -689,11 +681,8 @@ interface GlintHtmlElementAttributesMap {
['HTMLSourceElement']: HTMLSourceElementAttributes;
['HTMLStyleElement']: HTMLStyleElementAttributes;
['HTMLTableElement']: HTMLTableElementAttributes;
['HTMLTableSectionElement']: HTMLTableSectionElementAttributes;
['HTMLTableCellElement']: HTMLTableCellElementAttributes;
['HTMLTemplateElement']: HTMLTemplateElementAttributes;
['HTMLTextAreaElement']: HTMLTextAreaElementAttributes;
['HTMLTableSectionElement']: HTMLTableSectionElementAttributes;
['HTMLTableCellElement']: HTMLTableCellElementAttributes;
['HTMLTableSectionElement']: HTMLTableSectionElementAttributes;
['HTMLTimeElement']: HTMLTimeElementAttributes;
Expand All @@ -702,6 +691,12 @@ interface GlintHtmlElementAttributesMap {
['HTMLUListElement']: HTMLUListElementAttributes;
['HTMLVideoElement']: HTMLVideoElementAttributes;
['HTMLElement']: GlobalHTMLAttributes;
['HTMLBodyElement']: GlobalHTMLAttributes;
['HTMLDataListElement']: GlobalHTMLAttributes;
['HTMLHtmlElement']: GlobalHTMLAttributes;
['HTMLPictureElement']: GlobalHTMLAttributes;
['HTMLSpanElement']: GlobalHTMLAttributes;
['HTMLTitleElement']: GlobalHTMLAttributes;
Copy link
Contributor Author

@ijlee2 ijlee2 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GlobalHTMLAttributes may not be the correct thing to use. For simplicity, I used it like the default value that we see for HTMLElement on line 693.

If there's a better Attributes type to use, I suggest making the change in a separate pull request.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

}
}

Expand Down