Set mode #53
Open
Set mode #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldmud0
reviewed
May 6, 2019
| const MAV_CMD_DO_SET_MODE = 176; | ||
| const MAV_RESULT_ACCEPTED = 0; | ||
| const MAV_RESULT_TEMPORARILY_REJECTED = 1; | ||
| const MAV_RESULT_IN_PROGRESS = 5; |
Member
There was a problem hiding this comment.
Frankly, I don't know what to do with all these constants
| if (fields.type !== MAV_TYPE_FIXED_WING) | ||
| logger.warn(`Unknown autopilot ${fields.autopilot}`); | ||
| if (fields.autopilot !== MAV_AUTOPILOT_ARDUPILOTMEGA) | ||
| logger.warn(`Unknown vehicle type ${fields.type}`); |
Member
There was a problem hiding this comment.
These error messages are swapped
| await cleanupObj.wait(); | ||
| } | ||
|
|
||
| async function _sendCommandLong(mav, modeNumber, confirmation) { |
Member
There was a problem hiding this comment.
The name of this function is a little misleading since it's hardcoded to set MAV_CMD_DO_SET_MODE.
We should just abstract the whole COMMAND_LONG procedure to its own function, and then have sendMode call that procedure.
| || fields.result === MAV_RESULT_IN_PROGRESS) { | ||
| return; | ||
| } else { | ||
| let err = Error('COMMAND_ACK returned CMD ID ' + fields.result); |
Member
There was a problem hiding this comment.
Suggested change
| let err = Error('COMMAND_ACK returned CMD ID ' + fields.result); | |
| let err = Error('COMMAND_ACK returned CMD ID ' + fields.result); | |
| const err = new Error(`Plane responded to mode request with error code ${fields.result}`); |
|
|
||
| expect(res.status).toEqual(200); | ||
| expect(res.body.pos.lat).toBeTruthy(); | ||
| expect(res.body.mode.name).toEqual('MANUAL'); |
Member
There was a problem hiding this comment.
We need test coverage for setting the mode
| 6: 'FBWB', | ||
| 7: 'CRUISE', | ||
| 8: 'AUTOTUNE', | ||
| 10: 'AUTO', |
Member
There was a problem hiding this comment.
what did they do to mode 9... o_o
Member
|
This may destabilize telemetry and is not currently needed by any services, so I will merge this after competition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the current mode of the plane as a string and set it in the telemetry overview protobuf message.