Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

Get Thrift IDL from Meta::thriftIDL #61

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kriskowal
Copy link
Contributor

This allows TCurl to automatically obtain a ThriftIDL file from the service if one was not provided.

@prashantv
Copy link
Contributor

Before doing this, I think we should update our libraries to use the newer thriftIDL response:
https://github.com/uber/tchannel/blob/master/thrift/meta.thrift

Since it's a backwards incompatible change, I feel like we should make the change before we start using it in production.

@kriskowal
Copy link
Contributor Author

@prashantv Roger. Based on this work, it would be convenient to consolidate that entire shape into a single endpoint, both entry and map of sources. We appear to have elected to not burden static analysis and fetch-by-location on the client, with all that implies in flexibility/latency, so we may as well go all the way.

@kriskowal
Copy link
Contributor Author

I am gifting this branch to @malandrew to carry it over the line. This will require the implementation of Meta::thriftIDL properly in tchannel-{node,python?,go?,java??}

@andrewdeandrade
Copy link
Contributor

This will land as part of the completion branch. I'm going to look into checking if the different language versions of tchannel all support this endpoint since that needs to happen before this feature can be useful.

@kriskowal
Copy link
Contributor Author

Fixes #10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants