Fix: DLL dependencies not copied to target folder #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you modify one of the samples to use this case ? |
|
Does |
Collaborator
ideally as well yes if this applies. In general we try to have the same behavior for msbuild + fastbuild. |
Contributor
Author
I’ve added the fix to msbuild too. I’ll see later if I find an example to copy or improve on, but I’m not sure when I’ll have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My DLL project depends on another project that copies DLLs to the target folder.
For example:
conf.TargetCopyFilesToSubDirectory.Add(new KeyValuePair<string, string>(@"[project.SharpmakeCsPath]/bin/x64/D3D12Core.*", "D3D12"));)Currently, the copy dependencies of DLL projects are ignored.
This change fixes that issue so that dependent DLLs are correctly copied to the target folder.