Skip to content

Fix: DLL dependencies not copied to target folder #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firesgc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: DLL dependencies not copied to target folder #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a555d
Fix: DLL dependencies not copied to target folder
firesgc Oct 24, 2025
9d3d41b
Update Vcxproj.cs
firesgc Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sharpmake.Generators/FastBuild/Bff.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ List<string> skipFiles
{
if (isLastSubConfig) // post-build steps on the last subconfig
{
if (isOutputTypeExe || isOutputTypeAppleApp || conf.ExecuteTargetCopy)
if (isOutputTypeExeOrDllOrAppleApp || conf.ExecuteTargetCopy)
{
if (conf.CopyDependenciesBuildStep != null)
throw new NotImplementedException("CopyDependenciesBuildStep are not supported with FastBuild");
Expand Down
6 changes: 5 additions & 1 deletion Sharpmake.Generators/VisualStudio/Vcxproj.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,11 @@ IList<string> skipFiles
if (conf.IsFastBuild) // copies handled in bff
continue;

if (conf.Output != Project.Configuration.OutputType.Exe && !conf.ExecuteTargetCopy)
bool isOutputTypeExe = conf.Output == Project.Configuration.OutputType.Exe;
bool isOutputTypeDll = conf.Output == Project.Configuration.OutputType.Dll;
bool isOutputTypeExeOrDll = isOutputTypeExe || isOutputTypeDll;

if (!isOutputTypeExeOrDll && !conf.ExecuteTargetCopy)
continue;

var copies = ProjectOptionsGenerator.ConvertPostBuildCopiesToRelative(conf, context.ProjectDirectory);
Expand Down